From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11453 invoked by alias); 24 Aug 2012 11:18:35 -0000 Received: (qmail 11444 invoked by uid 22791); 24 Aug 2012 11:18:33 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 11:18:19 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7OBIGa1007497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Aug 2012 07:18:16 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7OBIEMU008781; Fri, 24 Aug 2012 07:18:15 -0400 Message-ID: <503762F6.3080804@redhat.com> Date: Fri, 24 Aug 2012 11:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Wei-cheng Wang CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix memory-region overlapping checking References: <1591920.sFon8Oz8ME@qiyao.dyndns.org> <1450628.xUgDUToN8c@qiyao.dyndns.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00713.txt.bz2 On 08/16/2012 11:02 AM, Wei-cheng Wang wrote: > Hi Yao, > > Thanks for your correction. > I wasn't aware of that rule and wondered what the message is used for. > > After I reviewed the cases, I think the cases should be altered a little. > When testing against 0x30-0x0, 0x50-0x70 is no different than 0x40-0x50, > so I remove it and add various boundary cases. > > Below is the altered one based on your fix. I just tried this test out, and noticed that it doesn't produce any fail without the gdb fix, while Yao's does. Could you sort that out, please? Thanks! -- Pedro Alves