From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1695 invoked by alias); 23 Aug 2012 12:29:30 -0000 Received: (qmail 1685 invoked by uid 22791); 23 Aug 2012 12:29:28 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 12:29:15 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T4WXB-0002Cz-Cp from Yao_Qi@mentor.com ; Thu, 23 Aug 2012 05:29:13 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Aug 2012 05:29:13 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Thu, 23 Aug 2012 05:29:12 -0700 Message-ID: <50362211.7030005@codesourcery.com> Date: Thu, 23 Aug 2012 12:29:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 2/2] Remove pass in skip_unwinder_tests References: <877gt1zbr5.fsf@fleche.redhat.com> <1345715389-20955-1-git-send-email-yao@codesourcery.com> <1345715389-20955-2-git-send-email-yao@codesourcery.com> <50360B4B.70806@redhat.com> In-Reply-To: <50360B4B.70806@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00656.txt.bz2 On 08/23/2012 06:51 PM, Pedro Alves wrote: > Do we really need to replace gdb_test_multiple with send_gdb/gdb_expect? No. > gdb_test_multiple will only issue fails in the internal errors cases. > I find it acceptable that see nothing most the time, and see a FAIL > when something goes really really wrong. More acceptable than the > timeouts we likely get with send_gdb/gdb_expect in the same really > really wrong cases, that is. I thought gdb_test_multiple contributes PASS to test summary by mistake. Here is a new version, which only removes 'pass' and keep gdb_test_multiple there. -- Yao gdb/testsuite: 2012-08-23 Yao Qi * lib/gdb.exp (skip_unwinder_tests): Remove pass. --- gdb/testsuite/lib/gdb.exp | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 0b02f76..97e79af 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2104,23 +2104,17 @@ proc skip_unwinder_tests {} { set ok 1 gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" { -re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" { - # Pass the test so we don't get bogus fails in the results. - pass "check for unwinder hook" set ok 0 } -re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" { - pass "check for unwinder hook" } -re "No symbol .* in current context.\r\n$gdb_prompt $" { - # Pass the test so we don't get bogus fails in the results. - pass "check for unwinder hook" set ok 0 } } if {!$ok} { gdb_test_multiple "info probe" "check for stap probe in unwinder" { -re ".*libgcc.*unwind.*\r\n$gdb_prompt $" { - pass "check for stap probe in unwinder" set ok 1 } -re "\r\n$gdb_prompt $" { -- 1.7.7.6