From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28803 invoked by alias); 22 Aug 2012 18:43:22 -0000 Received: (qmail 28786 invoked by uid 22791); 22 Aug 2012 18:43:18 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 18:43:01 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MIh0aQ000442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Aug 2012 14:43:01 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7MIgwtc005514 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 22 Aug 2012 14:43:00 -0400 Message-ID: <50352832.7090607@redhat.com> Date: Wed, 22 Aug 2012 18:43:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA] Include GNUlib config.h Content-Type: multipart/mixed; boundary="------------050400040707050900000202" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00629.txt.bz2 This is a multi-part message in MIME format. --------------050400040707050900000202 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Content-length: 911 Hi, I've been working on some bugs dealing with charset conversions when I noticed the following regression from 7.4: (gdb-7.4) p string $1 = L"A¢B" (gdb-7.5_or_HEAD) p string $1 = L"AB" A little bisecting yielded the following commit as the cause: http://sourceware.org/ml/gdb-patches/2012-04/msg00646.html If you grok that message, you'll notice that it mentions changes to defs.h, gdbserver/server.h, and gdbserver/gdbreplay.c to include this new file (*files* actually - one for gdb, one for gdbserver). It appears that those files were never committed. [I *hate* it when that happens. :-)] Do we want to throw this on the 7.5 branch as well? Keith ChangeLog 2012-08-22 Keith Seitz * defs.h: Include build-gnulib/config.h gdbserver/ChangeLog 2012-08-22 Keith Seitz * server.h: Include build-gnulib-gbserver/config.h. * gdbreplay.c: Likewise. --------------050400040707050900000202 Content-Type: text/x-patch; name="include-gnulib-config_h.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="include-gnulib-config_h.patch" Content-length: 1407 Index: defs.h =================================================================== RCS file: /cvs/src/src/gdb/defs.h,v retrieving revision 1.322 diff -u -p -r1.322 defs.h --- defs.h 22 Aug 2012 17:48:51 -0000 1.322 +++ defs.h 22 Aug 2012 18:35:14 -0000 @@ -27,6 +27,7 @@ #endif #include "config.h" /* Generated by configure. */ +#include "build-gnulib/config.h" #include #include Index: gdbserver/server.h =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.h,v retrieving revision 1.98 diff -u -p -r1.98 server.h --- gdbserver/server.h 27 Jul 2012 08:09:12 -0000 1.98 +++ gdbserver/server.h 22 Aug 2012 18:35:14 -0000 @@ -21,6 +21,7 @@ #define SERVER_H #include "config.h" +#include "build-gnulib-gdbserver/config.h" #ifdef __MINGW32CE__ #include "wincecompat.h" Index: gdbserver/gdbreplay.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/gdbreplay.c,v retrieving revision 1.34 diff -u -p -r1.34 gdbreplay.c --- gdbserver/gdbreplay.c 4 Jan 2012 08:17:23 -0000 1.34 +++ gdbserver/gdbreplay.c 22 Aug 2012 18:35:14 -0000 @@ -19,6 +19,8 @@ along with this program. If not, see . */ #include "config.h" +#include "build-gnulib-gdbserver/config.h" + #include #if HAVE_SYS_FILE_H #include --------------050400040707050900000202--