From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93999-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3103 invoked by alias); 22 Aug 2012 18:01:32 -0000
Received: (qmail 3090 invoked by uid 22791); 22 Aug 2012 18:01:28 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 18:01:10 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MI18Z9021001	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 22 Aug 2012 14:01:08 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7MI16j5029705;	Wed, 22 Aug 2012 14:01:07 -0400
Message-ID: <50351E62.4080607@redhat.com>
Date: Wed, 22 Aug 2012 18:01:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
MIME-Version: 1.0
To: "Joseph S. Myers" <joseph@codesourcery.com>
CC: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc"
References: <Pine.LNX.4.64.1208101705020.7722@digraph.polyomino.org.uk> <50260D91.5070000@codesourcery.com> <Pine.LNX.4.64.1208131630060.21427@digraph.polyomino.org.uk>
In-Reply-To: <Pine.LNX.4.64.1208131630060.21427@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00628.txt.bz2

Hi Joseph,

I'm not an ARM expert, but this looks fine to me.  Go ahead.

On 08/13/2012 05:30 PM, Joseph S. Myers wrote:

> +if [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} $opts] {
> +    untested ${testfile}.exp

See <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.

"In untested calls, please spell out the reason the test ends up untested, instead of just writing
 the test name, as with the latter we just end up with the test name duplicated in
 the gdb.sum output. For example: "

Something like:

  untested "Failed to compile $srcfile"

is sufficient.

> +    return -1
> +}
> +
> +if ![runto_main] then {
> +    untested ${testfile}.exp

  untested "could not run to main"

> +    return -1
> +}
> +
> +gdb_test "stepi" "0x\[0-9a-fA-F\]+ in main \\(\\)" "stepi for bx pc"

You can use dejagnu's $hex global instead of "0x\[0-9a-fA-F\]+" .

> +
> +gdb_test "x /i \$pc" \
> +    "0x\[0-9a-fA-F\]+ <main\\+4>:\[ \t\]+mov\[ \t\]+r0,\[ \t\]+#0.*" \
> +    "stepi reached correct instruction"
> 

Ditto.

-- 
Pedro Alves