From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15736 invoked by alias); 21 Aug 2012 18:41:37 -0000 Received: (qmail 15563 invoked by uid 22791); 21 Aug 2012 18:41:34 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Aug 2012 18:41:21 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LIfKeB024003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 Aug 2012 14:41:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7LIfJDq009487; Tue, 21 Aug 2012 14:41:19 -0400 Message-ID: <5033D64E.1020106@redhat.com> Date: Tue, 21 Aug 2012 18:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] gdb.base/valgrind-infcall.exp compat. with Ubuntu 10.04.4 References: <20120807064303.GA4739@host2.jankratochvil.net> <5033D14B.4090801@redhat.com> <20120821182731.GA2980@host2.jankratochvil.net> In-Reply-To: <20120821182731.GA2980@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00591.txt.bz2 On 08/21/2012 07:27 PM, Jan Kratochvil wrote: > On Tue, 21 Aug 2012 20:19:55 +0200, Pedro Alves wrote: >> On 08/07/2012 07:43 AM, Jan Kratochvil wrote: >>> set continue_count 1 >>> -while 1 { >>> +set loop 1 >>> +while {$loop} { >>> set test "continue #$continue_count" >>> gdb_test_multiple "continue" "" { >>> -re "Invalid free\\(\\).*: main .*\r\n$gdb_prompt $" { >>> pass $test >>> - break >>> + # In Ubuntu 10.04.4 environments 'break' does not work here. >>> + set loop 0 >>> } >> >> For archaeology, and for knowing when can we stop caring for this issue, >> it would be nice(r) IMO to know the tcl/expect version that triggered this issue. > > This was "v1" patch, there is also "patchv2". > > "patchv2" fixes also the case of "The program is not being run". I believe > the Doug's problem was due to it and not due to the "break" statement. But > I failed to reproduce the Doug's problem so I left it as is. > > The comment just states the bugreport, nothing more. Understood. The comment is still there on v2, so the point still stands though. -- Pedro Alves