Re: [RFC] Don't allow setting register in non-innermost frame

Eli Zaretskii
2012-09-07T11:27:58Z

> Date: Fri, 7 Sep 2012 18:19:28 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <dje@google.com>, <tromey@redhat.com>, <gdb-patches@sourceware.org>
>
> On 09/07/2012 06:10 PM, Eli Zaretskii wrote:
> >> Date: Fri, 7 Sep 2012 18:00:37 +0800
> >> From: Yao Qi <yao@codesourcery.com>
> >> CC: Tom Tromey <tromey@redhat.com>, <gdb-patches@sourceware.org>
> >>
> >>> I think this is NEWS-worthy.
> >>>
> >>
> >> I add a NEWS entry.
> >
> > Thanks. But its text says "when assigning" without explaining enough
> > for the reader to understand what "assigning" are we talking about.
> > So I suggest to mention the commands that are affected ('set', IIUC),
> > and perhaps give an example.
> >
>
> How about them below?
>
> * GDB will display a warning when assigning to registers, for example
> "set $eax=0x1", in non-innermost frames.
>
> or
>
> * GDB will display a warning when assigning to registers by command
> "set" in non-innermost frames.

If "set" is the only command, then the second variant is better. But
isn't the same true of the MI equivalent?