From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id D8084385DC1C for ; Sat, 23 May 2020 12:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8084385DC1C Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-Z1c0ReAoOOSeHO8X9mJLTA-1; Sat, 23 May 2020 08:24:24 -0400 X-MC-Unique: Z1c0ReAoOOSeHO8X9mJLTA-1 Received: by mail-wr1-f72.google.com with SMTP id q24so117926wra.14 for ; Sat, 23 May 2020 05:24:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kfWZRbMhOZpIUK/6jo1OFdX1AtY8z7rQLJjVmd1uV/s=; b=EKxefOObE+wFQkrbM7GDJxps2ISCNYmIvcNxj9ef8hPKRzjxefUhsramPtWi8/8xb2 fA9shSPyOuyDVCsGRX0y+kfXKdzyOdUSY/wm1KKll7MzqN+5Kx1Iuc4xeGUM9q97VLB7 vFIB/uzMLFeHnHCy4MmQKsRbeaHxFDGW7F4sChLABM36jpBIY7g2v4hif89k9JAaITmI tBI+JIapgKHtHLNBgcNr7BTcc8lo6kZ5PIvS0GX3EUo4SkL0mh1oDBI7ma+3CjeCqIVV gzFKNz+x2nepMaxfJvck2KdDGmGR7PE47ch/0L8NzihWmJGtvqEybctgS/jKmUoPl+wH CWUg== X-Gm-Message-State: AOAM533IsLIpkYu4hocrXorNkAyg5KzFXm/MpF42m1/Fy7KuvMjnPiGJ T31XWeWfINr98m1iRhAvMvJOIci3sNQh1EpGUxfP1OhoEEWQl9KrdMt4DvGtK1HK6cN44waABKI qiAeJjUJ6c7ElQjR9AGoo0g== X-Received: by 2002:adf:f24b:: with SMTP id b11mr7726402wrp.313.1590236663603; Sat, 23 May 2020 05:24:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyV1JOslGFL5CD6llBWTGtLyrWIg5DDGvmBuEfe0QoFtrVeL5qA5+uZ8xdBJoPou/vVuCiqGQ== X-Received: by 2002:adf:f24b:: with SMTP id b11mr7726394wrp.313.1590236663482; Sat, 23 May 2020 05:24:23 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z16sm2997238wmf.3.2020.05.23.05.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 May 2020 05:24:22 -0700 (PDT) Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles To: Tom Tromey , Simon Marchi via Gdb-patches References: <20200512210913.5593-1-simon.marchi@efficios.com> <875zcn1xwp.fsf@tromey.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> Date: Sat, 23 May 2020 13:24:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <875zcn1xwp.fsf@tromey.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 12:24:41 -0000 On 5/22/20 10:07 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> The big difference between v1 and v2 is how the split is done. > [...] > > Thank you so much for doing this. This is a big improvement over the > approach I took. > > I read through the patches. It was difficult to do without glazing over > a bit, so I'm not sure I really did a good job. However, I'm > comfortable with the direction you've taken here. I skimmed through the patches, glazing over a lot. The direction seems good to me too, FWIW. Just wanted to say, kudos for continuing this effort, and thanks for all the work. Pedro Alves