From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1882 invoked by alias); 9 Aug 2012 04:44:23 -0000 Received: (qmail 1874 invoked by uid 22791); 9 Aug 2012 04:44:22 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 04:44:09 +0000 Received: by weys10 with SMTP id s10so28347wey.0 for ; Wed, 08 Aug 2012 21:44:07 -0700 (PDT) Received: by 10.180.84.164 with SMTP id a4mr3536453wiz.12.1344487447701; Wed, 08 Aug 2012 21:44:07 -0700 (PDT) Received: from [192.168.1.104] (HSI-KBW-46-223-133-48.hsi.kabel-badenwuerttemberg.de. [46.223.133.48]) by mx.google.com with ESMTPS id q4sm8887912wix.9.2012.08.08.21.44.06 (version=SSLv3 cipher=OTHER); Wed, 08 Aug 2012 21:44:06 -0700 (PDT) Message-ID: <50234015.2060509@gmail.com> Date: Thu, 09 Aug 2012 04:44:00 -0000 From: Ralf Corsepius User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: gdb-7.5 branch ready for first release? References: <20120803134518.GZ27483@adacore.com> <50201D0C.50005@gmail.com> <87boilf6x6.fsf@fleche.redhat.com> In-Reply-To: <87boilf6x6.fsf@fleche.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00278.txt.bz2 On 08/08/2012 10:46 PM, Tom Tromey wrote: >>>>>> "Ralf" == Ralf Corsepius writes: > > Ralf> Would such a patch be acceptable or is using inttypes.h/stdint.h being > Ralf> considered a "no-go"? > > I can't speak to the sim changes. > > For this one: > > Ralf> diff --git a/gdb/symfile.c b/gdb/symfile.c > Ralf> index 01252e2..01720fa 100644 > Ralf> --- a/gdb/symfile.c > Ralf> +++ b/gdb/symfile.c > Ralf> @@ -2889,8 +2889,8 @@ allocate_symtab (const char *filename, struct objfile *objfile) > Ralf> last_objfile_name); > Ralf> } > Ralf> fprintf_unfiltered (gdb_stdlog, > Ralf> - "Created symtab 0x%lx for module %s.\n", > Ralf> - (long) symtab, filename); > Ralf> + "Created symtab 0x%p for module %s.\n", > Ralf> + symtab, filename); > Ralf> } > > Rather than %p I think it is the norm in gdb to use %s with > host_address_to_string. OK, thanks for the pointer. I'll try to take this into account when revisiting this issue next time [1]. Ralf [1] Due to vaction, this is unlikely to happen before Aug 20 ;)