From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8986 invoked by alias); 8 Aug 2012 20:46:08 -0000 Received: (qmail 8977 invoked by uid 22791); 8 Aug 2012 20:46:07 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 20:45:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q78KjsvH019320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Aug 2012 16:45:54 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q78KjqJD017777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 8 Aug 2012 16:45:53 -0400 Message-ID: <5022D000.7090502@redhat.com> Date: Wed, 08 Aug 2012 20:46:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: Re: [PATCH/obvious] Remove unused variable in parse_breakpoint_sals References: <5022CE8B.5000202@uglyboxes.com> In-Reply-To: <5022CE8B.5000202@uglyboxes.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00269.txt.bz2 On 08/08/2012 01:39 PM, Keith Seitz wrote: > I am committing this as obvious. And this time, including the patch! diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 03719d4..b24f71c 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -9115,8 +9115,6 @@ static void parse_breakpoint_sals (char **address, struct linespec_result *canonical) { - char *addr_start = *address; - /* If no arg given, or if first arg is 'if ', use the default breakpoint. */ if ((*address) == NULL