From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13081 invoked by alias); 3 Aug 2012 16:43:31 -0000 Received: (qmail 13062 invoked by uid 22791); 3 Aug 2012 16:43:26 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,TW_VG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 16:43:12 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 13:43:10 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 3 Aug 2012 13:42:56 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 42D02352004E for ; Fri, 3 Aug 2012 12:42:52 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73Gg5Is26804466 for ; Fri, 3 Aug 2012 13:42:05 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q73EghaR004651 for ; Fri, 3 Aug 2012 11:42:43 -0300 Received: from [9.12.224.99] ([9.12.224.99]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q73Egc97004541; Fri, 3 Aug 2012 11:42:39 -0300 Message-ID: <501BFF87.801@linux.vnet.ibm.com> Date: Fri, 03 Aug 2012 16:43:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , Pedro Alves , Sergio Durigan Junior , Philippe Waroquiers , Joel Brobecker , gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: [commit+7.5] [patchv2] Write bpt at the ON_STACK bpt address References: <5012B1B6.1030003@redhat.com> <1343339398.2258.119.camel@soleil> <20120727184633.GA14182@host2.jankratochvil.net> <20120731073643.GA18696@host2.jankratochvil.net> <501B03E4.1020209@linux.vnet.ibm.com> <501B2271.6030406@redhat.com> <87lihwoy14.fsf@fleche.redhat.com> <20120803143011.GA32485@host2.jankratochvil.net> <501BE7E4.1030703@linux.vnet.ibm.com> <20120803150740.GA2159@host2.jankratochvil.net> In-Reply-To: <20120803150740.GA2159@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12080316-1524-0000-0000-0000034F261D X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00118.txt.bz2 On 08/03/2012 12:07 PM, Jan Kratochvil wrote: > On Fri, 03 Aug 2012 17:01:56 +0200, Edjunior Barbosa Machado wrote: >> the patch below aborts the testcase if vgdb remote connection is closed, >> avoiding the testsuite to get stuck in the `continue' loop that happens when >> occurs the internal-error. It also considers the leading `.' for _start(), >> which is expected in ppc64. > > OK with the change below, so that the same testcase name appears during diffs > of various testsuite results. > > >> --- a/gdb/testsuite/gdb.base/valgrind-infcall.exp >> +++ b/gdb/testsuite/gdb.base/valgrind-infcall.exp > [...] >> @@ -97,6 +97,10 @@ while 1 { >> pass $test >> break >> } >> + -re "Remote connection closed.*\r\n$gdb_prompt $" { >> + fail "Remote connection closed. Testcase aborted" > > fail "$test (remote connection closed)" > >> + return -1 >> + } >> -re "\r\n$gdb_prompt $" { >> pass "$test (false warning)" >> } > > > Thanks, > Jan > Thanks! Checked in with the aforementioned change: http://sourceware.org/ml/gdb-cvs/2012-08/msg00036.html Btw, is it OK for 7.5 branch too? -- Edjunior