From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15671 invoked by alias); 3 Aug 2012 15:02:33 -0000 Received: (qmail 15652 invoked by uid 22791); 3 Aug 2012 15:02:30 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,TW_VG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 15:02:09 +0000 Received: from /spool/local by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 12:02:04 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp05.br.ibm.com (10.172.0.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 3 Aug 2012 12:02:03 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 2DC27352004D for ; Fri, 3 Aug 2012 11:02:00 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73F1B2x44302388 for ; Fri, 3 Aug 2012 12:01:11 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q73D1p1X019459 for ; Fri, 3 Aug 2012 10:01:52 -0300 Received: from [9.12.224.99] ([9.12.224.99]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q73D1l6G019411; Fri, 3 Aug 2012 10:01:48 -0300 Message-ID: <501BE7E4.1030703@linux.vnet.ibm.com> Date: Fri, 03 Aug 2012 15:02:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , Pedro Alves , Sergio Durigan Junior , Philippe Waroquiers , Joel Brobecker , gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: [commit+7.5] [patchv2] Write bpt at the ON_STACK bpt address References: <5012B1B6.1030003@redhat.com> <1343339398.2258.119.camel@soleil> <20120727184633.GA14182@host2.jankratochvil.net> <20120731073643.GA18696@host2.jankratochvil.net> <501B03E4.1020209@linux.vnet.ibm.com> <501B2271.6030406@redhat.com> <87lihwoy14.fsf@fleche.redhat.com> <20120803143011.GA32485@host2.jankratochvil.net> In-Reply-To: <20120803143011.GA32485@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12080315-2362-0000-0000-000007FE9B35 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00114.txt.bz2 On 08/03/2012 11:30 AM, Jan Kratochvil wrote: > On Fri, 03 Aug 2012 16:22:47 +0200, Tom Tromey wrote: >>>>>>> "Pedro" == Pedro Alves writes: >> >> Pedro> Curious. But is the cause the same? If something sending C-c to gdb >> Pedro> at the "wrong" time? >> >> It could be any exception thrown at the wrong spot in any sniffer. >> It would be interesting to know exactly where the original exception is >> thrown. I am still not sure that my fix is the correct one. Maybe it >> really is better to fix the sniffers. Or maybe do both. > > Yes, IMO it would be better. During the sniffers entryval virtual tailcall > frames path evaluation gets in effect which heavily throws exceptions and > successfully TRY_CATCHes them. I am not aware of any problem there, just the > exceptions are common nowadays due to it during unwinding. > > > Thanks, > Jan > Hi, the patch below aborts the testcase if vgdb remote connection is closed, avoiding the testsuite to get stuck in the `continue' loop that happens when occurs the internal-error. It also considers the leading `.' for _start(), which is expected in ppc64. Ok? Thanks, -- Edjunior gdb/testsuite/ 2012-08-03 Edjunior Machado * gdb.base/valgrind-infcall.exp: Expect leading `.' on ppc64's symbols. Abort if vgdb remote connection is closed. diff --git a/gdb/testsuite/gdb.base/valgrind-infcall.exp b/gdb/testsuite/gdb.base/valgrind-infcall.exp index f2aa1ad..5faa8c8 100644 --- a/gdb/testsuite/gdb.base/valgrind-infcall.exp +++ b/gdb/testsuite/gdb.base/valgrind-infcall.exp @@ -85,7 +85,7 @@ unset_board_info fileid clean_restart $executable -gdb_test "$vgdbcmd" " in _start .*" "target remote for vgdb" +gdb_test "$vgdbcmd" " in \\.?_start .*" "target remote for vgdb" gdb_test "monitor v.set gdb_output" "valgrind output will go to gdb.*" @@ -97,6 +97,10 @@ while 1 { pass $test break } + -re "Remote connection closed.*\r\n$gdb_prompt $" { + fail "Remote connection closed. Testcase aborted" + return -1 + } -re "\r\n$gdb_prompt $" { pass "$test (false warning)" }