From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93411-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9272 invoked by alias); 1 Aug 2012 20:23:21 -0000
Received: (qmail 9255 invoked by uid 22791); 1 Aug 2012 20:23:20 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 20:23:06 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q71KN6Tu025729	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 1 Aug 2012 16:23:06 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q71KN4wh018115;	Wed, 1 Aug 2012 16:23:05 -0400
Message-ID: <50199028.6060208@redhat.com>
Date: Wed, 01 Aug 2012 20:23:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: Sergio Durigan Junior <sergiodj@redhat.com>,        GDB Patches <gdb-patches@sourceware.org>,        Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Adjust `pc-fp.exp' for ppc64/s390x (PR 12659)
References: <m3mx2fmxmb.fsf@redhat.com> <5018ECBE.4020007@redhat.com> <87vch2s83x.fsf@fleche.redhat.com>
In-Reply-To: <87vch2s83x.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00040.txt.bz2

On 08/01/2012 08:52 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
>>> # Regression test for
>>> # http://sourceware.org/bugzilla/show_bug.cgi?id=12659
>>> gdb_test "info register pc fp" \
>>> -    "pc: ${valueof_pc}\[\r\n\]+fp: ${valueof_fp}\[\r\n\]+"
>>> + "pc(:)?.*${valueof_pc}(.*${hex} <.*>)?\[\r\n\]+fp:
>>> ${valueof_fp}\[\r\n\]+"
> 
> Pedro> Relaxing the output like that means that inadvertent changes to x86's
> Pedro> or ppc/s390x output might go unnoticed.  It's best to have
> 
> In this particular case, the check is really just to verify that the
> named register, and nothing else, appears at the start of the line.
> 
> Before 12659 was fixed, "info register pc fp" printed:
> 
> sp fp: blah blah
> fp: blah blah
> 
> The "fp" on the first line was the bogus bit.
> 
> I think the test would remain correct, with regards to what it was
> intended to check, if it even went as far as "pc: .*\[\r\n\]+fp: .*";
> checking the values is additional here.

Ah, in that case, I agree.

-- 
Pedro Alves