From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24850 invoked by alias); 30 Jul 2012 18:06:08 -0000 Received: (qmail 24840 invoked by uid 22791); 30 Jul 2012 18:06:06 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 18:05:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6UI5ZBP018199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jul 2012 14:05:35 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6UI5WMY007781 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 30 Jul 2012 14:05:34 -0400 Message-ID: <5016CCEC.2040006@redhat.com> Date: Mon, 30 Jul 2012 18:06:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" CC: asmwarrior@gmail.com Subject: Re: [RFA] Fix number lexing, again References: <5016B87B.8070004@redhat.com> <87394941ff.fsf@fleche.redhat.com> In-Reply-To: <87394941ff.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00771.txt.bz2 On 07/30/2012 10:13 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> While the list of growing terminations for the string is getting > Keith> tediously long, I don't think inverting the test would be any > Keith> shorter/clearer. WDYT? > > I agree. > The patch is ok; so is the test suite patch. > > Keith> PS. Also recommending this for 7.5. > > Yes please. All committed. Thank you! Keith