Re: [RFC] remove set_tfile_traceframe and cur_traceframe_number

[Pedro Alves <palves@redhat.com>]

On 06/27/2012 02:47 PM, Yao Qi wrote:
> Hi,
> I can't see the necessity to use function set_tfile_traceframe and
> variable cur_traceframe_number.  IIUC, both set_tfile_traceframe
> and cur_traceframe_number are equivalent to remote.c:set_remote_traceframe
> and remote.c:remote_traceframe_number.  set_remote_traceframe
> and remote_traceframe_number are used to switch between traceframe
> and live inferior in a lazy mode.  However, this requirement doesn't
> exists in tfile, because GDB only reads from trace file.  This is
> the reason I propose to remove them.  Regression tested on native
> and gdbserver on x86_64-linux.  OK to apply?


OK.  Thanks.

Nits:

> 2012-06-27  Yao Qi  <yao@codesourcery.com>
> 
> 	* tracepoint.c (set_tfile_traceframe): Removed.

"Remove."

> 	(tfile_trace_find, tfile_fetch_registers): Update callers.
> 	(tfile_xfer_partial, tfile_get_trace_state_variable_value): Likewise.
> 	Remove cur_traceframe_number.

This is a global.  So should be:

 	(cur_traceframe_number): Remove.

and should be first thing in the entry.

-- 
Pedro Alves