From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21923 invoked by alias); 26 Jul 2012 18:21:53 -0000 Received: (qmail 21850 invoked by uid 22791); 26 Jul 2012 18:21:51 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 18:21:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6QIKmAT025357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Jul 2012 14:21:33 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6QGZXP8021610 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Thu, 26 Jul 2012 12:35:35 -0400 Message-ID: <501171D5.3060705@redhat.com> Date: Thu, 26 Jul 2012 18:21:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: gdb-patches ml Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers References: <500C0A1F.8040106@redhat.com> <87k3xusgan.fsf@fleche.redhat.com> <87lii9ne95.fsf@fleche.redhat.com> <50106327.5000004@redhat.com> <87pq7ifx3u.fsf@fleche.redhat.com> In-Reply-To: <87pq7ifx3u.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00634.txt.bz2 On 07/26/2012 06:52 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> Ok for HEAD and 7.5? > > One nit... > > Keith> + && !isspace(*PARSER_STREAM (parser)) && *PARSER_STREAM (parser) != ',' > > Space after "isspace" Ha. I didn't even notice that had been committed. > Ok with that fix, thanks. > Committed to HEAD and 7.5. Thank you for the review. Keith