From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18970 invoked by alias); 26 Jul 2012 15:31:41 -0000 Received: (qmail 18962 invoked by uid 22791); 26 Jul 2012 15:31:41 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 15:31:29 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6QFVQdM005919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Jul 2012 11:31:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6QFVPTL002611; Thu, 26 Jul 2012 11:31:25 -0400 Message-ID: <501162CC.4080800@redhat.com> Date: Thu, 26 Jul 2012 15:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] attach to command_option-changed observer. References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1343146252-22558-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00620.txt.bz2 On 07/24/2012 05:10 PM, Yao Qi wrote: > + else if (strncmp (parse->command, "gdb-set", sizeof ("gdb-set") - 1 ) == 0) > + { > + int *p = &mi_suppress_notification[MI_SUPPRESS_COMMAND]; I honestly have trouble mapping "MI_SUPPRESS_COMMAND" to -gdb-set. This is about =option-changed, so I think MI_SUPPRESS_OPTION_CHANGED would be clearer. -- Pedro Alves