From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31165 invoked by alias); 25 Jul 2012 13:48:33 -0000 Received: (qmail 31148 invoked by uid 22791); 25 Jul 2012 13:48:30 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 13:48:17 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PDmEDB008852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Jul 2012 09:48:14 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6PDmCpo028998; Wed, 25 Jul 2012 09:48:13 -0400 Message-ID: <500FF91C.9030009@redhat.com> Date: Wed, 25 Jul 2012 13:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [RFC] new board file 'remote-host-native.exp' References: <1343135426-20959-1-git-send-email-yao@codesourcery.com> <500EC87A.10806@redhat.com> <1804874.ivBX2v1I8f@qiyao.dyndns.org> In-Reply-To: <1804874.ivBX2v1I8f@qiyao.dyndns.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00522.txt.bz2 On 07/25/2012 08:27 AM, Yao Qi wrote: > On Tuesday, July 24, 2012 05:08:26 PM Pedro Alves wrote: >> Why natively? I'd think you could use both this host board with e.g., >> a gdbserver target board file. I suggest: >> >> +# This file is a dejagnu "board file" and is used to run the testsuite >> +# against local host, in remote host mode. >> >> I'd even rename the file to local-remote-host.exp. >> > > Looks term "native" can be used for target board file, while term > "local/remote" can be used for host board file. Comment is fixed. > I thought of 'local-remote-host.exp' before, but gave it up since I > was afraid people are confused by its name. I am fine with it. If nobody complains, let's run with it. >>> +set_board_info username YOUR.USER.NAME >> >> We can make this pick up the current user by default on at least GNU/Linux, >> and probably other Unixen: >> >> set_board_info username $::env(USER) >> > > What does these double colons mean? I use $env(USER), and it works fine. Ah, I just basically copy/pasted from : "To access the env array within a Tcl proc, one needs to tell the proc that env is a global array. There are two ways to do this. $::env(PATH) global env ; puts $env(PATH) can alternatively used to identify that the variable is globally available; however, you have to remember to use the global command in EVERY proc that you need to use env. Using the $::env notation is shorter." Since this is global code anyway (not within a proc) $env should be fine (and is the style used elsewhere). Go ahead and make that change. It's true, most of my tcl foo is web search based. :-) > Yes, with ${board}_download, files are not copied to somewhere else through > ssh, so the test is faster. One line of comment is added. How about the > new one? Looks fine to me. Thanks! -- Pedro Alves