From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13209 invoked by alias); 25 Jul 2012 06:45:35 -0000 Received: (qmail 13201 invoked by uid 22791); 25 Jul 2012 06:45:34 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 06:45:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6P6jHHm025115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Jul 2012 02:45:17 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6P6jFwA030635 for ; Wed, 25 Jul 2012 02:45:16 -0400 Message-ID: <500F95FB.5060904@redhat.com> Date: Wed, 25 Jul 2012 06:45:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4]: Make "python" start a standard Python prompt References: <770F6E2B-70F5-4DF9-8E01-BD4F5FDC7AB1@cs.umd.edu> In-Reply-To: <770F6E2B-70F5-4DF9-8E01-BD4F5FDC7AB1@cs.umd.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00513.txt.bz2 On 07/16/2012 09:47 PM, Khoo Yit Phang wrote: > Hi, > > I'd like to resubmit my patches to make the "python" command start a standard Python prompt (I've completed the copyright assignment). As discussed back in January-February (http://permalink.gmane.org/gmane.comp.gdb.patches/71971), I've updated my patch to move the old "python" to "python-block". Apologies for the delay, I've been mulling if this constitutes an API change. Because we have an API promise, we cannot materially alter the behavior of an API without providing compatibility that is transparent and automatic for older scripts. I am not sure what the implication for your change is. If a user has a script (or some code in .gdbinit, or whatever ) that uses "python" will it break that user's script? If so it is probably better to leave python as it is, and use python-interactive (or whatever) for the interactive prompt. Judging that you changed the testsuite to use python-block, I am guessing it is a material and non-compatible change? I guess I need more data, testing. I am replying here now as you pinged the patch (which is totally fine, just updating you). Cheers Phil