Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers

Hui Zhu
2012-07-25T12:57:50Z

On Wed, Jul 25, 2012 at 3:35 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2012-07-24 Hui Zhu <hui_zhu@mentor.com>
>>> * linespec.c (linespec_lexer_lex_number): Update comments,
>>> change the return and add check to make sure the input is
>>> the decimal numbers.
>>> (linespec_lexer_lex_one): If linespec_lexer_lex_number return
>>> false, call linespec_lexer_lex_string.
>
>>> +static int
>>> +linespec_lexer_lex_number (linespec_parser *parser, linespec_token *tokenp)
>>> {
>>> linespec_token token;
>
> After this change, I think 'token' is unused.

Oops.

>
> The patch is ok if you update it to remove this.
>
> thanks,
> Tom

I fixed it and committed this patch to trunk and 7.5.

Thanks,
Hui