From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10062 invoked by alias); 19 Jul 2012 17:33:48 -0000 Received: (qmail 10051 invoked by uid 22791); 19 Jul 2012 17:33:46 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jul 2012 17:33:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6JHXTUV006088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Jul 2012 13:33:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6JHXRAY026133; Thu, 19 Jul 2012 13:33:28 -0400 Message-ID: <500844E7.4040103@redhat.com> Date: Thu, 19 Jul 2012 17:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH] sigall.exp and friends: centralize signals list. References: <20120719143526.8328.28449.stgit@brno.lan> <87zk6vy88i.fsf@fleche.redhat.com> In-Reply-To: <87zk6vy88i.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00363.txt.bz2 On 07/19/2012 06:24 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> +for {set i 0;} {$i < [llength $signals]} {incr i;} { > Pedro> + # Skip the first. > Pedro> + if { $i == 0 } { > Pedro> + continue > Pedro> + } > Pedro> + > Pedro> + set sig [lindex $signals $i] > Pedro> + test_one_sig $sig > Pedro> +} > > The ";"s aren't needed. They're only needed in Tcl if you write > multiple statements on one line, but we don't do that anyhow, or > shouldn't, since it is bad style. Thanks. I copied that from elsewhere, and didn't think much about it. I'll grep and fix the instances I find. > > For the above I think it is more idiomatic in Tcl to write: > > foreach sig $signals { > if {$sig == "ABRT"} { > continue > } > test_one_sig $sig > } > > That said, I don't care if you leave it as-is. I actually started out that way. Then I thought that: - There's no guarantee that we won't have duplicate signals on the list. If the test some day generates two SIGABRTs, we'd still only want to skip only the first of those, so we'd have to change the loop. - We really want to skip the first signal, because that's handled before the loop. It doesn't matter which signal it is. So I concluded that not hard coding a signal name was a little better, and went with a for with index, which expresses the idea naturally. -- Pedro Alves