From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YA8IJD6pF2JeJgAAWB0awg (envelope-from ) for ; Thu, 24 Feb 2022 10:50:22 -0500 Received: by simark.ca (Postfix, from userid 112) id 90CD61F3C8; Thu, 24 Feb 2022 10:50:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F2941EE1F for ; Thu, 24 Feb 2022 10:50:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06236385803F for ; Thu, 24 Feb 2022 15:50:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06236385803F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1645717821; bh=MQWRXyMHh37l43wGH+r4fpwkalwRTpUBUKEVIRbLbUQ=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KJN81C4RN/AcrCYxmjKoCgbMn8uiU67uY6SEoWT3M9xBfhiFShft7YAGUsk18T0/j j65RvkuXSt9nLKLZMd284ZZKldvuEzxGk08Jx+ReuVSNm1iQPtYBF48R2haczOTQC1 YCZfcuj52ZNlPsIAWWXAbTv5fa2qtyYzs5ScKKqQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 489653858038 for ; Thu, 24 Feb 2022 15:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 489653858038 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21OFnUuJ019204 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Feb 2022 10:49:36 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21OFnUuJ019204 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C65021EE1F; Thu, 24 Feb 2022 10:49:28 -0500 (EST) Message-ID: <50083fbd-bb00-da50-26a6-0bc5c6dcc34d@polymtl.ca> Date: Thu, 24 Feb 2022 10:49:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC][PATCH v3 1/1][PR gdb/24069] gdb/darwin: skip over WIFSTOPPED wait4 status Content-Language: en-US To: Philippe Blain , gdb-patches@sourceware.org References: <20220216141540.96514-1-levraiphilippeblain@gmail.com> <20220224142321.585-1-levraiphilippeblain@gmail.com> <20220224142321.585-2-levraiphilippeblain@gmail.com> In-Reply-To: <20220224142321.585-2-levraiphilippeblain@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Feb 2022 15:49:31 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Louis-He <1726110778@qq.com>, Dominique Quatravaux , Sam Warner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-02-24 09:23, Philippe Blain wrote: > From: Dominique Quatravaux > > On modern Darwin's, there appears to be a new circumstance in which a > MACH_NOTIFY_DEAD_NAME message can be received, and which was not > previously accounted for: to signal the WIFSTOPPED condition in the > debuggee. In that case the debuggee is not dead yet (and in fact, > counting it as dead would cause a zombie leak - A process in such a > state reparents to PID 1, but cannot be killed). > > - Read and ignore such messages (counting on the next exception > message to let us know of the inferior's new state again) > - Refactor logging so as to clearly distinguish between the > MACH_NOTIFY_DEAD_NAME cases (WIFEXITED, WIFSTOPPED, signal, or > something else), and warn in the last case > > Co-authored-by: Louis-He <1726110778@qq.com> > Co-authored-by: Philippe Blain > > ChangeLog: > > 2022-02-05 Dominique Quatravaux > > PR gdb/24609 > * gdb/darwin-nat.c (darwin_nat_target::decode_message): Also > check for WIFSTOPPED upon MACH_NOTIFY_DEAD_NAME. Thanks, pushed. Simon