From: Pedro Alves <palves@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Initialize status in gdbserver/linux-low.c
Date: Mon, 16 Jul 2012 16:06:00 -0000 [thread overview]
Message-ID: <50043BFF.6000205@redhat.com> (raw)
In-Reply-To: <CAEG7qUx0-9haWev6_9R37jgeWd6UsSnxtU58FbexF+Uz6PsfJQ@mail.gmail.com>
On 07/16/2012 04:54 PM, Sterling Augustine wrote:
> Hi,
>
> As the code for handle_extended_wait exists today, status can be used
> uninitialized on line 486 if pull_pid_from_list on line 451 returns
> true.
If pull_pid_from_list returns true, then it has written to status.
Sounds like you're getting a false positive warning?
>
> This near-trivial patch initializes it to zero at the declaration.
>
> OK for mainline?
If this is indeed a false warning, then this is okay with
a "Avoid GCC false warning" comment or some such.
--
Pedro Alves
next prev parent reply other threads:[~2012-07-16 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 15:55 Sterling Augustine
2012-07-16 16:06 ` Pedro Alves [this message]
2012-07-16 17:09 ` Sterling Augustine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50043BFF.6000205@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox