Re: [RFC] Display exact entered expression for watchpoints

Pierre Muller
2002-11-19T11:06:46Z

At 20:53 14/11/2002, Daniel Jacobowitz wrote:
>On Thu, Nov 14, 2002 at 12:00:18PM +0100, Pierre Muller wrote:
>> When I watch a memory location,
>> I almost always use hexadecimal notation.
>>
>> For instance lets say that I want to watch
>> the memory containing the value of gdb_stderr
>> On my linux box
>> (top-gdb)p &gdb_stderr
>> returns
>> $1 = (struct ui_file **) 0x823b5cc
>> (ok, here I could simply use 'watch gdb_stderr,
>> but in some other cases like dynamically allocated memory I can't).
>> if I enter
>> (top-gdb) watch *0x823b5cc
>> Hardware watchpoint 3: *136558028
>> (top-gdb) inf b
>> Num Type Disp Enb Address What
>> 1 breakpoint keep y 0x080f0d79 in internal_error
>> at ../../src/origdb/utils.c:810
>> 2 breakpoint keep y 0x080783eb in info_command
>> at ../../src/origdb/cli/cli-cmds.c:202
>> silent
>> return
>> 3 hw watchpoint keep y *136558028
>> (top-gdb)
>>
>>
>> After my patch, I get
>> (top-gdb) watch *0x823b5cc
>> Hardware watchpoint 3: *0x823b5cc
>> (top-gdb) inf b
>> Num Type Disp Enb Address What
>> 1 breakpoint keep y 0x080f0d79 in internal_error
>> at ../../src/origdb/utils.c:810
>> 2 breakpoint keep y 0x080783eb in info_command
>> at ../../src/origdb/cli/cli-cmds.c:202
>> silent
>> return
>> 3 hw watchpoint keep y *0x823b5cc
>>
>>
>> I really prefer the later,
>
>
>I like this behavior a lot better too; I see the number and get
>hopelessly confused as to what I'm watching :) Michael, Jim, do you
>think this will cause any problems? Watch doesn't take an implicit
>argument the way that break does, so a string should always be
>available.

So, I think that after looking into the MAINTAINERS file,
I need approval from either Jim Blandy or Michael Snyder
on this RFC.

Original RFC is