From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oE5EJ1q8QmhVEwMAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 06:00:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=VUvOgXzb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C6C01E11C; Fri, 6 Jun 2025 06:00:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BA3311E089 for ; Fri, 6 Jun 2025 06:00:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A98B385782C for ; Fri, 6 Jun 2025 10:00:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A98B385782C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=VUvOgXzb Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20619.outbound.protection.outlook.com [IPv6:2a01:111:f403:2406::619]) by sourceware.org (Postfix) with ESMTPS id 7FBA53857820 for ; Fri, 6 Jun 2025 09:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FBA53857820 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FBA53857820 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2406::619 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749203984; cv=pass; b=LR1Q/U1Q29lYZv3I/MWashyb+hvajmuHSZiLtWhaa9CbnJ37o6QEluZGwGiUGDlwapMj1KxrvO7IPN0BXNnb+yYVBe3ECe9XE85blo9QUK1IzCyi21d6wYHtCjrZMQqlOkPwsJ87k+adp3bgXsApdW1cUMs/8pTEF0lTP/bL9YE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749203984; c=relaxed/simple; bh=W7K4C7rVWL8sJYgnTbkAp/1NZYlhjYQRC6zRtYTdLIY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=E1i0cAWPJ4ueEAW+9SdMAU5TMTs1TZKXEQRp5I/8+EzKPfwtgdP1WxGOOMvI/g61jlQGQsUmhHDsCfmbV6zM3TkhD9BapzmxkkJKmQXmcz1gjUxF+5lUhih8G7sJE8+A9LcEHuds5Hq/D8USAYheT+GuzklWU0MpQEhUwuP9fnY= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FBA53857820 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Juh4ELpcn6fEZX0kdSOh86W1PA74lzcd+HAS+Gfy91hhvLZg3rZ5Uo9R3WHcICv0Wqltstk0gc1LCoa60g5avQCZiSch5p8ENhiZRsSJUU+wFBzPUp25Gs5Vr5Sp8Sib17l5WAtEWV9GWvDGtIF++YRxlFak9NgITZXyMNZNIbIjZbrJxqjdllWDOg+LXZTeQrnqHwfNa6lZY7IPqGEjlOR4+fF2Kn+lyRpp7ur7mcK23whALuFfXAblkCv4tIo/lQnjbXVE8QQ3+/7DhZRXc6m0Lkeoapw3npOAn6fRUzD7MaeIrgrd+ZUzquprqBLqY463C8uZpmuHzC07hBvj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQQN+htTACcN+EPqsjOQ+uz+qKAlNG+kpOiF7ayCxqo=; b=isNuKsIzkWP1lW739C8/xX46hbClOOSkjrOJkIUWgJ0gtHtEqBEQCZr0p0kDHypnZ9P/lgZeaODTvclp1s4qPoC94HiWKYleJLDWEpwAhiH+OiLw6+gPOMwwdATKceqXAOXRhxrGdA52fMYNtDKu1Mhli8hL9q8E3ML09LhKQiN0oG71pzV+3TfplaBXTcqtYIcnhwtEjCZN/SESE9WyAiJF7iwIXNNYCZRvysh+Wag6T38eB3GDx6JF52uMgItcPWwhpPuthi86CTdWfh1FJ2yArgW1saT2ipu/bE/zItnE8oAqTPmWhNyuwQ00s0Bphw54AFxqDrH72+7AF5O4Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQQN+htTACcN+EPqsjOQ+uz+qKAlNG+kpOiF7ayCxqo=; b=VUvOgXzbDfxu1+9RBJkRu3JCQ/RflGPx48V8XM1ij8SdqU2JRSGPaY7wxYxuzeMKoE+HGTF39PvzX5c8QMH6tRvHPtKSRBLJVoLoXbABFElrGoYWcYVfSxmPEXVcyHDxxW4+LLZ+kTlje5VbkBD4irAhr3ckleWhzxpfmthj3rM= Received: from MW4PR03CA0218.namprd03.prod.outlook.com (2603:10b6:303:b9::13) by PH7PR12MB6420.namprd12.prod.outlook.com (2603:10b6:510:1fc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.34; Fri, 6 Jun 2025 09:59:38 +0000 Received: from SJ5PEPF000001CE.namprd05.prod.outlook.com (2603:10b6:303:b9:cafe::85) by MW4PR03CA0218.outlook.office365.com (2603:10b6:303:b9::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Fri, 6 Jun 2025 09:59:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001CE.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8792.29 via Frontend Transport; Fri, 6 Jun 2025 09:59:37 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 6 Jun 2025 04:59:36 -0500 Date: Fri, 6 Jun 2025 10:59:28 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH 1/5] gdb/amd-dbgapi: remove unnecessary AMD_DBGAPI_EVENT_KIND_NONE argument Message-ID: <4vafb3d43fe7qrbb3czhsghs6c2bpbhueofhwfovgy273blpzb@js7hocmkm3ci> References: <20250605201657.418206-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250605201657.418206-1-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CE:EE_|PH7PR12MB6420:EE_ X-MS-Office365-Filtering-Correlation-Id: e1a6d5d0-2fc0-497b-7127-08dda4e0d945 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?OmHZXvnJoWUF9sA9KN+2x2d8s03A8yhupfBTG/LCWMjNS+EwIw5+9UJ//aRk?= =?us-ascii?Q?0lzphSU5NqUoQTpIfNYw469GfakRJB05d1lt4Xaxs02vHMh9xXd4qHBiSNj6?= =?us-ascii?Q?rBLgaC7CwJ1dSF9N6MCTG9jNYzt+/VVZl9HpFWxUnYFWavwqPkf38z0dgczi?= =?us-ascii?Q?QG8GEJp4fZFfs+qXGaZmySyfxj8a8QQWNOTJdYBU//B/m4oXR1dyOmOeyIkY?= =?us-ascii?Q?8C8isJ2Ow46u/eoG6pmXleeyh3yZimRrVeBTEjsX9nu0nQKKV/1J+o8jkesx?= =?us-ascii?Q?dgpTVp6gahEK/614fT7MWLfIIQSwhi1vGns9370PnvtQFsJt/+xE05AbIHXK?= =?us-ascii?Q?QCyBe9lbIf2BuSqSQihbz0kqFOWfgwx5DJelcLBvhJ0jWGLTb2CIqxHROc9d?= =?us-ascii?Q?U1ImHYqyoyAWE5a9aoYIcx2rxpMmyZkJu/QRTPwQ3oUtanR05Wa0hWIlm6x3?= =?us-ascii?Q?2NeJBWoyI30+ivYpbsZ64YBH9Tgq1NiDPN6SekRzkuZkRSzOmbvapEXL5tDM?= =?us-ascii?Q?WuDexkVlMCshB9fFEbdA54BntasYgIEScfdu3/DT84xBRRxa0qmwzix+dwLM?= =?us-ascii?Q?ECxhrtEfQNyKPWQMxTULK6/HMqoWmwP6BPQU+TdLAxkzujneLAli0zP/0+oe?= =?us-ascii?Q?LUaY3pvATnAzwwsB8glVStInzqmP1nJK7q9NRULU0bkqYI4wUy5X3ltsAUE8?= =?us-ascii?Q?GdAzxOgIH2tL7GxJL0dOCdgPTRmp4uaiiMYfLWqesQg9BlLDSUSdM4ZEPjWX?= =?us-ascii?Q?0xiunlJOhtFiKjB9qsREHMogf792fUBKspsp52opEp6KkjoSXJvOMFX0U4DP?= =?us-ascii?Q?0GnUw9Y8bqqWew8M18FZnDU8FhugELXs4dl2SaG5aOXuHjj9Mhyopz3yHcLX?= =?us-ascii?Q?/BNm9J6G0HhQvUGX25d6eT3NY+kakm4nswMy3NhsOlgUkahJ2kKkftl3J8RS?= =?us-ascii?Q?lc+59B+wFp+V1YPQXJUcJ8bhvKXEzQaAmxwQMUrp52q2warP09XUYNLQAwZp?= =?us-ascii?Q?9rUPjua7+dzMIM1Rdf/DfoqCvG+K318/z7DgqSx/9RQelG1K5FrH2t6wKIN0?= =?us-ascii?Q?Mi5l1Kud1gCBBi8xRZVlPedoNQkPvECSDY3N/PcRk+7gNpv7thOPnlfZlvSo?= =?us-ascii?Q?rJRmo1pQrg7CmVIdhvAcvlWb/Jvje2p1VqnoXTIcXTbq19AGSN+lxZ82IXgT?= =?us-ascii?Q?iK3gItZ5YROoB3lQVVNAbBFfo1v4HhbLiWhROykHbUpgDaBF6Ayi+3Qht3/E?= =?us-ascii?Q?viGiyifJIx3S56SEJ1aFJiBtiuLwGd+WqA90Y/tmy2gQcfWJU4mRpTktVfVL?= =?us-ascii?Q?Kjx9famVdo48logPB3gXtU5GgUQBjOH3pGJQkdu996BDRtwzwTx5+TQ2mX6p?= =?us-ascii?Q?bE8j0Dgn/tPpxtntziM52IfsnLpB9Wogu5eSce1YzKM6NVjAROPes5GQyGE7?= =?us-ascii?Q?/9KTPq3od6RkCEz0dGd2qDP0zwZ7bgjAxW6yXURhsNmny8zzOzkqAeRcgAWZ?= =?us-ascii?Q?2RlQ19FH5/+AmLXYUNO/9E9nCNHxZHo09tVD?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2025 09:59:37.9961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1a6d5d0-2fc0-497b-7127-08dda4e0d945 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6420 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, Jun 05, 2025 at 04:16:24PM -0400, Simon Marchi wrote: > Rely on the default value. Hi, This OK. Approved-By: Lancelot Six (amdgpu). Best, Lancelot. > > Change-Id: I08c683de005806c5c5d29ed7f9b0c6de81b49a01 > --- > gdb/amd-dbgapi-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 8e067b66bd86..c11e834aa408 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -1473,7 +1473,7 @@ amd_dbgapi_target::wait (ptid_t ptid, struct target_waitstatus *ws, > /* Drain the events for the current inferior from the amd_dbgapi and > preserve the ordering. */ > auto info = get_amd_dbgapi_inferior_info (current_inferior ()); > - process_event_queue (info->process_id, AMD_DBGAPI_EVENT_KIND_NONE); > + process_event_queue (info->process_id); > > std::tie (event_ptid, gpu_waitstatus) = consume_one_event (ptid.pid ()); > if (event_ptid == minus_one_ptid) > > base-commit: f118937c181f008f78496d299873c879648d2d1a > -- > 2.49.0