From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FQTfEIXEc2P8xRgAWB0awg (envelope-from ) for ; Tue, 15 Nov 2022 11:55:33 -0500 Received: by simark.ca (Postfix, from userid 112) id 35C521E124; Tue, 15 Nov 2022 11:55:33 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sChm6LoA; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DF9351E11E for ; Tue, 15 Nov 2022 11:55:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D62D38A8144 for ; Tue, 15 Nov 2022 16:55:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D62D38A8144 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668531332; bh=hce7kHNnPaikb26wbWWJnXcuQ+Fx18yEnKxaZrU8osM=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sChm6LoAtxSCd7cowiad2WpgvkfDKt+hCBKdUHI5rPzVVLQ3/65S3W/jZXHJxk+3F tENZ3YANHb2vG0c6FyIFfbh58NFwNcD7wptrVT2AISmswaSLSiGfFZWkOfgRu2WQyi 8vNF4n1ouGOXvM734P+rFM5Ap/KLuyOeUMV106QM= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7D84638133DC for ; Tue, 15 Nov 2022 16:55:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D84638133DC Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7FC8E1E11E; Tue, 15 Nov 2022 11:55:11 -0500 (EST) Message-ID: <4f9bbf3b-6a82-ea6f-7879-c1041539a3ff@simark.ca> Date: Tue, 15 Nov 2022 11:55:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2 ver 3] PowerPC, fix support for printing the function return value for non-trivial values. Content-Language: fr To: Carl Love , Ulrich Weigand , "gdb-patches@sourceware.org" , "tdevries@suse.de" Cc: "kevinb@redhat.com" , "will_schmidt@vnet.ibm.com" , "blarsen@redhat.com" References: <2db5ad69b32f4cda9c53b252ad37cd783f827c14.camel@de.ibm.com> <7f476265-c6a9-9fcf-ce13-ff550ea5e6f6@suse.de> <6ed2cf1714e5b8dc386e66b634b540efdf828ed5.camel@de.ibm.com> <4c6fc2c2180e0d470d8e70801a91a7ee234c5b68.camel@us.ibm.com> In-Reply-To: <4c6fc2c2180e0d470d8e70801a91a7ee234c5b68.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/15/22 11:04, Carl Love via Gdb-patches wrote: > On Tue, 2022-11-15 at 10:16 +0000, Ulrich Weigand wrote: >> Tom de Vries wrote: >>> On 11/14/22 17:47, Ulrich Weigand via Gdb-patches wrote: >>>> I believe all of Kevin's and Bruno's comments have been addressed >>>> in this version. I've reviewed it myself as well, and it looks >>>> good to me. >>>> This is OK. >>> On x86_64-linux, I run into a segfault: >>> [...] >>> (gdb) up >>> #1 0x0000000000852d94 in finish_command (arg=0x0, from_tty=0) >>> at /home/vries/gdb_versions/devel/src/gdb/infcmd.c:1887 >>> 1887 = check_typedef (sm->function->type ()->target_type >>> ()); >>> (gdb) p sm->function >>> $1 = (symbol *) 0x0 >> >> Ah, I missed that possibility, sorry. >> >> Carl, if sm->function is NULL, then the whole check needs >> to be skipped, and sm->return_buf should be set to 0. >> >> Can you come up with a fix along those lines (or else, >> just revert the patch for now)? Thanks! >> > Yes, I will take a look and see about fixing or reverting it ASAP. > > Carl > Just so you can test properly, I also see these failures that are likely due to the same bug: UNRESOLVED: gdb.base/foll-vfork.exp: exec: vfork parent follow, finish after tcatch vfork: finish UNRESOLVED: gdb.base/foll-vfork.exp: exec: vfork child follow, finish after tcatch vfork: finish UNRESOLVED: gdb.base/foll-vfork.exp: exit: vfork parent follow, finish after tcatch vfork: finish UNRESOLVED: gdb.base/foll-vfork.exp: exit: vfork child follow, finish after tcatch vfork: finish UNRESOLVED: gdb.base/sigaltstack.exp: finish to throw INNER UNRESOLVED: gdb.base/sigstep.exp: finish from handleri: leave signal trampoline Simon