From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 396DE385BF81 for ; Sat, 30 May 2020 16:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 396DE385BF81 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 846EB1E791; Sat, 30 May 2020 12:08:53 -0400 (EDT) Subject: Re: [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <20200529220350.k4g6kca42vs7y3r6@function> <4d1dce2c-84aa-2f05-6f90-705bb2842c90@simark.ca> <20200530155326.o364seuoi6burg3o@function> From: Simon Marchi Message-ID: <4f5f1015-6b4f-1808-f6a4-bfedb0506f08@simark.ca> Date: Sat, 30 May 2020 12:08:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200530155326.o364seuoi6burg3o@function> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 16:08:56 -0000 On 2020-05-30 11:53 a.m., Samuel Thibault wrote: > Simon Marchi, le sam. 30 mai 2020 10:57:42 -0400, a ecrit: >>> @@ -1106,12 +1109,12 @@ inf_validate_procs (struct inf *inf) >>> if (inferior_ptid == ptid_t (inf->pid)) >>> /* This is the first time we're hearing about thread >>> ids, after a fork-child. */ >>> - thread_change_ptid (inferior_ptid, ptid); >>> + thread_change_ptid (gnu_target, inferior_ptid, ptid); >> >> >> I think it would have been more straightforward and clean to use `inf->process_target ()` >> (assuming it's the correct thing to do), given that you have access to the appropriate >> inferior everywhere you made changes. > > I didn't see a way to access the inferior here (inf is a > gnu-nat.c-specific structure with no link to struct inferior) Ah I see. Well, I didn't check all code paths, but for example, for the one that goes: - gnu_nat_target::attach - inf_attach - inf_startup - inf_set_pid A solution would be to make all these inf_* functions to be private methods of the gnu_nat_target class. They would then pass `this` as the process_stratum_target. A bit like what was done in commit e7eee665a1524cc4569d0c2f5c9d4aa2be64c9e8 gdb: fix darwin-nat.c build / adapt to multi-target Even if you are not doing this, a good cleanup would be to make all those functions (like inf_attach) static. They are only used in gnu-nat.c, but are exported. Simon