From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5369 invoked by alias); 13 Dec 2017 23:03:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5358 invoked by uid 89); 13 Dec 2017 23:03:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 23:03:18 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2965C1555A; Wed, 13 Dec 2017 23:03:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCD13620A5; Wed, 13 Dec 2017 23:03:13 +0000 (UTC) Subject: Re: [patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer] To: Jan Kratochvil References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790576669.20186.17091294504362630191.stgit@host1.jankratochvil.net> <20170628212114.GA23559@host1.jankratochvil.net> <20170702142957.GA22686@host1.jankratochvil.net> <628074a3-b992-1d96-273e-ecdf1e90bd8c@redhat.com> <20171212165221.GA12449@host1.jankratochvil.net> <20171213215731.GA32208@host1.jankratochvil.net> <10aa4fac-5924-0620-297c-436f4386fe0b@redhat.com> Cc: gdb-patches@sourceware.org, Victor Leschuk From: Pedro Alves Message-ID: <4f4790f6-2eca-00a8-97c6-fc7b368273ba@redhat.com> Date: Wed, 13 Dec 2017 23:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <10aa4fac-5924-0620-297c-436f4386fe0b@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00327.txt.bz2 On 12/13/2017 10:15 PM, Pedro Alves wrote: > On 12/13/2017 09:57 PM, Jan Kratochvil wrote: >>> The .debug_names completely misses its support as it does not even produce >>> DW_IDX_type_unit. >> >> Here you are, could you also verify my regression testing for this patch? > > Thanks! I'm testing right away. Yep, it fixes all regressions compared to .gdb_index. Please fix the following nits and push: > + int dwarf5_offset_size () const { The '{' goes on the next line. > + /* A helper function that writes a single signatured_type to an > + debug_names. */ Typo: "to an" => "to a". OK with those fixed. Thanks, Pedro Alves