From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 9876B38A1032 for ; Tue, 17 Mar 2020 18:02:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9876B38A1032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584468164; bh=zK1pxKx+txKDs5Tm0O3hUjPgG6PGai//5H0rOgglwo0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=U3GhzxsqdXxzlXExrjIy39iJGhRf1vubqdhbbHxP5qxdYs6+WjgGoRgOmCpTT8Sy4 qD57B5E7rTWNkUZf8eUVckWdhk02Aw5BAprodtLD1wFBz+SjC679u9x6X2DZZG8KNe 9ET5ogc8xGAQtAhtJU45lUn+C580CaOLKLBG7vsc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M9Wyy-1jAxAO1y8y-005WbM; Tue, 17 Mar 2020 19:02:44 +0100 Subject: Re: [PATCH] Rename the read symbol to xread To: Christian Biesinger Cc: gdb-patches References: <20200317124532.22151-1-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <4f0eed4e-c649-a901-f0e5-c7dbfe65c8fd@gmx.com> Date: Tue, 17 Mar 2020 19:01:41 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="phru1Jg2ZoP80fdwSdLSnXwsbCvsgeSQZ" X-Provags-ID: V03:K1:1GdVA4Rc+jkCA8bV4lMkVd1iwlzb/AkALw8AzPF1YVPFKd78qMW Z/iMkKjUMG7EfHy0xIer0zeMiqRfwDwn/p0pwOvBdOdJpXxr9Xgo94GyuLkzO0/2m0jNgnO L9k2nl4xZsGjY18A1gCvPgE0js8tC3c2xc0oCC8fb8776swHKOaIXseSpuhEuYpcg1aRNgv v5+zzAJcvde4MS+52BMYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:TInFPrHL5Tw=:8GA/GU9Mb18D5SDhh5FlXR T56IeSxLIqviIRNwGfQax4LjcxbhLDQFb717KnL3FXsA/gy9kuUIZ4YQwrB6huzbz1oHzOv8i TnzdSHn/jhayChCMaPnykxkVNXieyjoQdpscwjW5qUrI7luEaoZWaHSeEyn8sAnRIeqsFXaLa bwcluCJDWFvM1ZSAihn6iuhkz+WMow8C7y5127eoNIKFS/Ut69AznnCdEon/ZgFxu/lhr8xVs 7Qk0ySZuY2s3zGJ4KqxKt8+OSdSgYD6lx7D6uZWkei+VzSn4PXwX6iaUJ0vy/LDRVxfVE+716 zT8QW3Dg7pyIwi9oQK4aTnS2NvAwPSYfaMTYbh3ixsTgsRaQLr6lOEYNG4QPUUIhtU6U7pzN5 4EE5ICBJTnQ60TRgyKh5Qq+VETQdLnCkwB7CMHGDySB4RjwLtrrNs3sKFrWcDqWhJuYclC+j0 Gaen2tFIgwxTa4D1/KZsuEOyVxjndtBkHuoTEwMYt+3Og12Ov2626EHoW9T8kNNmGfEyHftEs QbW9xfgVX4I1a8OXl0gvnfNsA6T1bsTzGL5emc8ecIB04EYBDNjfxQF8sR+C1Do4Ir9VdLI8k 5c9ggmmrYZ3wSXdJcc3CrJVXCq2rF7Er1ZjrBhA7QfUUJr2dvUUQbF6LVeXvunJw6LTepJpmD /Qs9HPnTUmGJX7bp5GASabpS0nF+xe8q/tKFtmkyXzCz05iuaYPmKF9FZwuccUPdvhpQG25ia cGNxrlWxot3cSW3wJClJneOFlmCbfOJl2Sc3zs/DMj7ae7CziNeyI0AFW0KgkEBSUO2f+xBnZ Mlm0EhHm5/oBKN4DuDWkGNPkFJYMWnKO/3AyRvzp29hgB5xbwD41k4ujDjLmZrbc2eEjzzw7z TDpLwoAZeBU5EjXKwLmXxxWG7zfJHK7fXouhbKv4hEq6sTXnYFNgDnETa2BZYw1I6RpAgqn5i 9UprqifhFt1j2VlSBNJE0gyV19tSBm6mSg8KAmzGF+I+sniv5JxtB0nVUQqUF2iYHrx1EBOeX wbRm0l0sFjjG4epX7qOzfyWpncSyqay9q0ykaOgRyBIhmSFYoMsNRjD4E1uZZXSnuZEJn9z9H MoispQDzxIOi8Pnqrm2UMXONlN2ZkBhjaxNMwNRazDDiWrUAcoo+mziquRhFieKkp0QdCq/mi rtacQAl/6pUI5sHSa5qqFI/VbUF2rclvUW7Z8lQ2JH7iqC4yS475AH06vmHt5wi412HSg= X-Spam-Status: No, score=-25.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 18:02:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --phru1Jg2ZoP80fdwSdLSnXwsbCvsgeSQZ Content-Type: multipart/mixed; boundary="zPkqN9KXrwV11c9TABm6wDfeJfD5Aol2v"; protected-headers="v1" From: Kamil Rytarowski To: Christian Biesinger Cc: gdb-patches Message-ID: <4f0eed4e-c649-a901-f0e5-c7dbfe65c8fd@gmx.com> Subject: Re: [PATCH] Rename the read symbol to xread References: <20200317124532.22151-1-n54@gmx.com> In-Reply-To: --zPkqN9KXrwV11c9TABm6wDfeJfD5Aol2v Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 17.03.2020 19:00, Christian Biesinger wrote: > On Tue, Mar 17, 2020 at 12:59 PM Kamil Rytarowski wrote: >> >> On 17.03.2020 18:51, Christian Biesinger wrote: >>> On Tue, Mar 17, 2020 at 7:46 AM Kamil Rytarowski wrote:= >>>> >>>> This avoids clashes with macro read in the NetBSD headers. >>> >>> Out of curiosity, what does NetBSD define read to? >>> >>> I think it would be useful to add a comment saying why this is called= xread. >>> >> >> NetBSD ships with SSP (stack smashing protector) support that >> conditionally redefines read(2). >> >> https://github.com/NetBSD/src/blob/trunk/include/ssp/unistd.h#L39 >=20 > Ah thanks. >=20 >> Is a comment in the commit message enough? >=20 > Not IMO, that's much harder to find... >=20 Where should I document this? in struct_reg? > Christian >=20 >>> Christian >>> >>>> --- >>>> gdb/user-regs.c | 18 +++++++++--------- >>>> 1 file changed, 9 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/gdb/user-regs.c b/gdb/user-regs.c >>>> index a232b1eb000..a968a18bc23 100644 >>>> --- a/gdb/user-regs.c >>>> +++ b/gdb/user-regs.c >>>> @@ -41,7 +41,7 @@ >>>> struct user_reg >>>> { >>>> const char *name; >>>> - struct value *(*read) (struct frame_info * frame, const void *bat= on); >>>> + struct value *(*xread) (struct frame_info * frame, const void *ba= ton); >>>> const void *baton; >>>> struct user_reg *next; >>>> }; >>>> @@ -60,7 +60,7 @@ struct gdb_user_regs >>>> >>>> static void >>>> append_user_reg (struct gdb_user_regs *regs, const char *name, >>>> - user_reg_read_ftype *read, const void *baton, >>>> + user_reg_read_ftype *xread, const void *baton, >>>> struct user_reg *reg) >>>> { >>>> /* The caller is responsible for allocating memory needed to stor= e >>>> @@ -68,7 +68,7 @@ append_user_reg (struct gdb_user_regs *regs, const= char *name, >>>> register list stored in the common heap or a specific obstack.= */ >>>> gdb_assert (reg !=3D NULL); >>>> reg->name =3D name; >>>> - reg->read =3D read; >>>> + reg->xread =3D xread; >>>> reg->baton =3D baton; >>>> reg->next =3D NULL; >>>> (*regs->last) =3D reg; >>>> @@ -82,10 +82,10 @@ static struct gdb_user_regs builtin_user_regs =3D= { >>>> }; >>>> >>>> void >>>> -user_reg_add_builtin (const char *name, user_reg_read_ftype *read, >>>> +user_reg_add_builtin (const char *name, user_reg_read_ftype *xread,= >>>> const void *baton) >>>> { >>>> - append_user_reg (&builtin_user_regs, name, read, baton, >>>> + append_user_reg (&builtin_user_regs, name, xread, baton, >>>> XNEW (struct user_reg)); >>>> } >>>> >>>> @@ -103,14 +103,14 @@ user_regs_init (struct gdbarch *gdbarch) >>>> >>>> regs->last =3D ®s->first; >>>> for (reg =3D builtin_user_regs.first; reg !=3D NULL; reg =3D reg-= >next) >>>> - append_user_reg (regs, reg->name, reg->read, reg->baton, >>>> + append_user_reg (regs, reg->name, reg->xread, reg->baton, >>>> GDBARCH_OBSTACK_ZALLOC (gdbarch, struct user_re= g)); >>>> return regs; >>>> } >>>> >>>> void >>>> user_reg_add (struct gdbarch *gdbarch, const char *name, >>>> - user_reg_read_ftype *read, const void *baton) >>>> + user_reg_read_ftype *xread, const void *baton) >>>> { >>>> struct gdb_user_regs *regs >>>> =3D (struct gdb_user_regs *) gdbarch_data (gdbarch, user_regs_d= ata); >>>> @@ -122,7 +122,7 @@ user_reg_add (struct gdbarch *gdbarch, const cha= r *name, >>>> regs =3D (struct gdb_user_regs *) user_regs_init (gdbarch); >>>> deprecated_set_gdbarch_data (gdbarch, user_regs_data, regs); >>>> } >>>> - append_user_reg (regs, name, read, baton, >>>> + append_user_reg (regs, name, xread, baton, >>>> GDBARCH_OBSTACK_ZALLOC (gdbarch, struct user_reg)= ); >>>> } >>>> >>>> @@ -214,7 +214,7 @@ value_of_user_reg (int regnum, struct frame_info= *frame) >>>> struct user_reg *reg =3D usernum_to_user_reg (gdbarch, regnum - m= axregs); >>>> >>>> gdb_assert (reg !=3D NULL); >>>> - return reg->read (frame, reg->baton); >>>> + return reg->xread (frame, reg->baton); >>>> } >>>> >>>> static void >>>> -- >>>> 2.25.0 >>>> >> >> --zPkqN9KXrwV11c9TABm6wDfeJfD5Aol2v-- --phru1Jg2ZoP80fdwSdLSnXwsbCvsgeSQZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5xEIYACgkQS7MI6bAu dmyR5xAArwwa0wx86qK0SDG+AZOVVS/pyROZvSdZr2ozoo1bfRT0bUJMshE4o6Vx m1+2/MVj/h3nC44N82qYzRaKJ7i8eRKb8/hWP8JvwWsGjH/+JYxbfYc1H4BwtvkI EoeyXADa3oq4qjXoPl0bbHITvUbZ2UJeSDsQPeXSa2CyldrZIrLw/q9L0GdV/cUt FN8jg4JkLAewM8qszxUn4c2i4KqR4TPaPSRaRTKlKXXT6aMU4+L1Ia6+Jxknz/xr KK4AEYJzK072/UT1xufJl2+zY8gLgNNQBk4LpkErKorVB03RCQF8Sl3V3hU7IpKK ppvyyXojw0K29nh3FGNVhnClJrJ2W/aAqOF9E+In9nIoPAWBplL2Z/HnR4bPXX+Q zxSefTk7MBW9fAxusbpGMBE6xOB0yqNAetCfJxWC7LElcaJ28ili+f353UKKM/v2 6kVLZ5k6wfm46fahi4QEHg1ZjrmvNtQUGVyiBh+K5n69IwCWxjL61v8lJ+6zLAP7 OHzG29CNzsCguSpIpciOjDe6XPDHkc6c/bISH1Wr9Sm+PMNUq8dVvSRJfoBIht3D lgap9nrVI8tBaDPVNSgwH2f+fZlR38rrRatAjzolF9SZPMoDgIrT4Juo9cfebg2M eluU/dpMSaX+1450gaB5R9L/ZQHisjMVsO5/EANH1cg4Yu1Pflg= =aKhS -----END PGP SIGNATURE----- --phru1Jg2ZoP80fdwSdLSnXwsbCvsgeSQZ--