From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fOkfErLDIGlQfBwAWB0awg (envelope-from ) for ; Fri, 21 Nov 2025 14:55:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1763754930; bh=An68JLKxR7XmwuU0iRsRA/rX+Etii381HYm0ps/93Jw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fxHl4AQTjncXRzs42bZTmI6/eCmFURfHqal7QcFKpTCKqXll2HaI3kbcANjsHVoBh H4qE+V5lz1aSzYBrq/sKIb1VGCM8923gNN+SlkYnBEe/TDiZQsFVcKuZFHix9idYrz fVSFBxXbprLshwlZMVZrJV3WywTZ8h4TIXXTh4+0= Received: by simark.ca (Postfix, from userid 112) id 3A8D31E048; Fri, 21 Nov 2025 14:55:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=uQsOy92g; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 85F201E048 for ; Fri, 21 Nov 2025 14:55:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20167384CBA7 for ; Fri, 21 Nov 2025 19:55:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20167384CBA7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=uQsOy92g Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EBBBD384CB86 for ; Fri, 21 Nov 2025 19:54:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBBBD384CB86 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBBBD384CB86 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763754896; cv=none; b=sPTNpCfH+CblGFihaCQs3zH9zKhhHiQYHxtQvb9MJ2a1M99l9Jq+pfucq/QFSCU3AWbHPvkBVF+EkYLdorwV4nXQ3iA/z/KfAWmvWEqJ8HZMzg8u9Tif5xgHtgnWsNlcrrzfAYrlqaOZWlLPZwpDoLV8Sho6AVqCHPdweDRJdU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763754896; c=relaxed/simple; bh=An68JLKxR7XmwuU0iRsRA/rX+Etii381HYm0ps/93Jw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sEZEZvhQmcJiAhUivhcJmomI1nf3SZJsX+Qxd8/LRBs9N1du3fJgx0LtOVNwEl4Cn7gVwC6QP/FUDdZb3PqBySubwvxj6QrV9nB1JM5YQGNupiBTL0wUaEZOPrpj7aYJrDaL3IKTVtlMfW5iJuoKJOr9KTzPO4f6sPAJgPKDIsY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBBBD384CB86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1763754895; bh=An68JLKxR7XmwuU0iRsRA/rX+Etii381HYm0ps/93Jw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uQsOy92gJEsbLtIbZUbrBctvN1N/hYMn2BuClRs8dYA0GxfgsMt59e7l0jDXb1mXp hcwdfCYF+bM9Kz7rcDcCsNWaf0Obbo6uHlUM09fYTkH0NmNFxoTe7FYkcZXobW+9My gxE/tODUs+YCUSdBqNrgGnXfG4Z9rFRy3MQgXD8M= Received: by simark.ca (Postfix) id 4373C1E048; Fri, 21 Nov 2025 14:54:55 -0500 (EST) Message-ID: <4ee2afa5-0944-4331-8e8c-c1c1c21f142e@simark.ca> Date: Fri, 21 Nov 2025 14:54:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] gdb/dwarf: store addr/offset/ref_addr sizes in dwarf2_per_cu To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20251107211041.520697-1-simon.marchi@efficios.com> <20251107211041.520697-6-simon.marchi@efficios.com> <87a50iq9tb.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87a50iq9tb.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-11-19 11:14, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> + /* Sizes for an address, an offset, and a section offset. These fields are > Simon> + set by cutu_reader when the unit is read. */ > Simon> + unsigned char m_addr_size = 0; > Simon> + unsigned char m_offset_size = 0; > Simon> + unsigned char m_ref_addr_size = 0; > > How about uint8_t instead. I don't mind doing that change, but why do you think it's better than "unsigned char" here? Simon