From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id D187A385BF81 for ; Fri, 5 Jun 2020 06:10:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D187A385BF81 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 425F4AED7; Fri, 5 Jun 2020 06:10:16 +0000 (UTC) Subject: Re: [PATCH 2/3] gdb: Don't reorder line table entries too much when sorting. To: Tom Tromey , Andrew Burgess Cc: gdb-patches@sourceware.org References: <87d0b8ahbn.fsf@tromey.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <4ee1276e-0e98-dc30-64d5-aafd74875412@suse.de> Date: Fri, 5 Jun 2020 08:10:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <87d0b8ahbn.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2020 06:10:15 -0000 On 24-01-2020 18:35, Tom Tromey wrote: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Don't reorder line table entries for the same address when sorting the > Andrew> line table, maintain the compiler given line order. Usually this will > Andrew> reflect the order in which lines are conceptually encountered at a > Andrew> given address. > > Thanks for the long explanation and the patch. > > I had a couple minor nits. > > Andrew> - /* Like the pending blocks, the line table may be > Andrew> - scrambled in reordered executables. Sort it if > Andrew> - OBJF_REORDERED is true. */ > Andrew> + const auto lte_is_less_than > Andrew> + = [] (const linetable_entry &ln1, > Andrew> + const linetable_entry &ln2)->bool > > I'd put spaces around the "->". > > > Andrew> + { > Andrew> + /* Note: this code does not assume that CORE_ADDRs can fit > Andrew> + in ints. Please keep it that way. */ > Andrew> + return (ln1.pc < ln2.pc); > > I don't think this comment adds anything any more. IMO it can just be > dropped. This commit caused the following regressions with target board readnow: ... +FAIL: gdb.ada/bp_c_mixed_case.exp: break +FAIL: gdb.arch/amd64-invalid-stack-top.exp: first backtrace, with error message +FAIL: gdb.arch/amd64-invalid-stack-top.exp: second backtrace, with error message +FAIL: gdb.arch/amd64-invalid-stack-top.exp: check mi -stack-list-frames command, first time +FAIL: gdb.arch/amd64-invalid-stack-top.exp: check mi -stack-list-frames command, second time +FAIL: gdb.arch/i386-bp_permanent.exp: single-step past permanent breakpoint +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: final_debug=0: step +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: final_debug=0: set-break: after resolving: break final +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: final_debug=0: set-break: after resolving: break gnu_ifunc +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=0: final_debug=0: set-break: after resolving: info breakpoints +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: final_debug=0: step +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: final_debug=0: set-break: after resolving: break final +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: final_debug=0: set-break: after resolving: break gnu_ifunc +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=0: resolver_debug=1: final_debug=0: set-break: after resolving: info breakpoints +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: step +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: set-break: after resolving: break final +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: set-break: after resolving: break gnu_ifunc +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=0: final_debug=0: set-break: after resolving: info breakpoints +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: step +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: set-break: after resolving: break final +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: set-break: after resolving: break gnu_ifunc +FAIL: gdb.base/gnu-ifunc.exp: resolver_attr=1: resolver_debug=1: final_debug=0: set-break: after resolving: info breakpoints +FAIL: gdb.base/solib-weak.exp: run to breakpoint - lib1 nodebug, lib2 nodebug, lib1 first +FAIL: gdb.base/solib-weak.exp: run to breakpoint - lib1 nodebug, lib2 nodebug, lib2 first +FAIL: gdb.base/solib-weak.exp: run to breakpoint - lib1 nodebug, lib2 debug, lib1 first +FAIL: gdb.base/solib-weak.exp: run to breakpoint - lib1 debug, lib2 nodebug, lib2 first +FAIL: gdb.base/step-symless.exp: step +FAIL: gdb.base/until-nodebug.exp: until 1 +FAIL: gdb.base/until-nodebug.exp: until 2 (the program exited) +FAIL: gdb.btrace/unknown_functions.exp: flat +FAIL: gdb.btrace/unknown_functions.exp: indented +FAIL: gdb.cp/minsym-fallback.exp: break C::f() +FAIL: gdb.cp/minsym-fallback.exp: break C::operator()() +FAIL: gdb.reverse/singlejmp-reverse.exp: reverse-step +FAIL: gdb.reverse/singlejmp-reverse.exp: reverse-next ... As well as the following progressions: ... +PASS: gdb.gdb/complaints.exp: breakpoint in captured_command_loop +PASS: gdb.gdb/python-interrupts.exp: breakpoint in captured_command_loop +PASS: gdb.gdb/python-selftest.exp: breakpoint in captured_command_loop +PASS: gdb.gdb/selftest.exp: breakpoint in captured_main ... The first regression is noted in PR25858 - "[readnow] FAIL: gdb.ada/bp_c_mixed_case.exp: break " ( https://sourceware.org/bugzilla/show_bug.cgi?id=25858 ). Thanks, - Tom