From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wT2xFFBxZ2rURDAAWB0awg (envelope-from ) for ; Mon, 27 Jul 2026 10:55:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 502CD1E099; Mon, 27 Jul 2026 10:55:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6AA531E099 for ; Mon, 27 Jul 2026 10:55:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 078264B99F74 for ; Mon, 27 Jul 2026 14:55:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 078264B99F74 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20a::7]) by sourceware.org (Postfix) with ESMTPS id 0CEA14BB1C07 for ; Mon, 27 Jul 2026 14:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CEA14BB1C07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CEA14BB1C07 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20a::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785164084; cv=pass; b=VZajXMoBQrxHTQxNVREhmLM9v3Ls/yBBVOh9FqjxgZMCFJkEU+z4j5ki2tXu9XCTs6zbcQI+WRmE9gX+jGPMKCvV08xLDEkwuVi2p4eC4EH2uE+29kzgYL6NUYQaELSmArrZ45y+kW/2KUPEbwR3bybS+Vc5zb4pFej5LHsO0TA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785164084; c=relaxed/simple; bh=wiDjhDLp6oxE4KXzKV7PVgEprpNcPRwdZHZXELTHHio=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=G9kvnkEkiLr1VOjQktUc6F2nWrRKRKCeUWPR6kODSuhqKeyj5qDyHs4aAy5EFZI+kI8AJAJ0XBgOye84YK7hC97dKc9y/PggAd9EhtcGErTXo53rKr2rkWZUqU40cAP1ZhrU9tI8LT0tkFvlSOH3wkus2PXxAg8UpgyP05QgIjg= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=gjhNI+vW DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CEA14BB1C07 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=A3zT9YcQiae1cGs07BqqCtlG2GiAj2qTpuXkK6aQDstIKgmmayeeydL6cleAfrJGHhqEeva14vx+XFLLZDlWW9+oGc+eLxIkrj5BBaZCM/vCwTW93l7JOvNristTxgRVEU2r4U2T7Ji2JTUDh0i/C6YQMnq4BIsXiGGuS3egsqzRwhf5JHC18azml47ZdjnBWzp1+K06ygRS7+sIKYgaP34pRgbQn3eUzYMW4GBh/sS53ftrMo/YvG+GlQXSKzknZwjou/gPCYnCk5IWWZUKlUbfqXEFiB1PlUp9ye1irAkaImNtQpoIQmxaVvZAni1K4EwDRkoTVOMtdoPBUdPrIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv6vm7qEsqx2i+IfUZRMyzbXsUGbGilBcT3fSyIjruE=; b=FH+El+y7ggTNqnRrbPwbpB9xXzmYAghl/M3orvNWRtkWBb6tDQKcAEFUrJt/tZpo0V5TB/XNjmMR121g3PNAnyJ4BdlAVStdYgEi3nKwnSBAm5Xyt1mBF/T3PasCEjMquT+T1+WPCc97RDS44ZL1tG3MR9JowBdfMf2pLQm0gEBGZRH3RKnLhwBS7urqoJy8SDIk4v0UwOHK5yZoRMOcI9aZEZ9BF3OG0arp0G28yhRY2AgSEmcibDzn3rzh7l5oxE1gZccRzT/PA1Bw5VPHv8wQhF3twk+DJn58Cfy7EUynZdXXOlop6+E4d6aREIoU0xD3vHC6gBalNpX+R9TRTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pv6vm7qEsqx2i+IfUZRMyzbXsUGbGilBcT3fSyIjruE=; b=gjhNI+vWY2QwjX40QHfYpYRVfYR9xZqFozmHbBvZYX6eIpp6Z1Wc88AZzQ9RhBvDdGrjJVUIrTBC10XArqd473bxn1X3TL+EGMAKvQOMkGcT4PhDDKecSH/zFxOH1RWifdDKDB5/NsEKNwnuo9jDkX9Dz9iLCUId9FC1N1ydxhY= Received: from AS4P195CA0015.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:5e2::12) by PA6PR08MB10470.eurprd08.prod.outlook.com (2603:10a6:102:3d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Mon, 27 Jul 2026 14:54:29 +0000 Received: from AMS0EPF000001B1.eurprd05.prod.outlook.com (2603:10a6:20b:5e2:cafe::20) by AS4P195CA0015.outlook.office365.com (2603:10a6:20b:5e2::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.13 via Frontend Transport; Mon, 27 Jul 2026 14:54:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF000001B1.mail.protection.outlook.com (10.167.16.165) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Mon, 27 Jul 2026 14:54:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q+nTtCzVavQxyAmNWjhhZJID7qY+vYkSmrV75fpj9F4Nmwn5yCbgpE5VJfmihfgP8i5N/Vzzrp4/bHP+hE7NfpCF41sTqEQbMSItRmbWbLIBJePb22uWn2B7kTwqK7XO50oQR5zi1x+4PvmbMq8a/V/k1RSrCdEek/WJcs+sGw3hzshXSTZLUK08GlfUKp9+TQQQ9WS3WNLUS2RLGivq8Zdqq0yDIhXkkEi6b0OUAgqduIYPAvpT/VXuzqLG7GBppKQ/RV9e8TA9aMxhXHA45Ci6WyU5KHuUqekrU+oJniRLh+MQz6nZhyun7JEA6vYn/dinwmTpuI3I11x3eqRC/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv6vm7qEsqx2i+IfUZRMyzbXsUGbGilBcT3fSyIjruE=; b=RFhBaUsLTqNRc4TF1ApLcdb+ltkKIAoq5VB5GL4gIrn5dKXDB2c3eD+4CDtuKNm1hd51qn4wQzFLQQIu9AMDpXH4AU8rt3LUyEQP88YW5gK8BMfNWynX/xQYsN96bmlRWdO7knjxw2gdyZqHHfxIZSBUE9yjc/fDUlU91n6xwZb642eC5aU5gZbO7n5bZVi7t40OUDXXqrxhV1sHigXTsLRRXmLrIPADYl+VRCaW654LwJxi0Jq0Hu5BP+G+FAofRpM99hPLhk6/QQJLv9MgxBTfJ8uC+qCF6vDMMP4i5L2Gei1Tj2eTSMKTnXJZXzmm73BoeUVZld9nEmLDvEy4hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pv6vm7qEsqx2i+IfUZRMyzbXsUGbGilBcT3fSyIjruE=; b=gjhNI+vWY2QwjX40QHfYpYRVfYR9xZqFozmHbBvZYX6eIpp6Z1Wc88AZzQ9RhBvDdGrjJVUIrTBC10XArqd473bxn1X3TL+EGMAKvQOMkGcT4PhDDKecSH/zFxOH1RWifdDKDB5/NsEKNwnuo9jDkX9Dz9iLCUId9FC1N1ydxhY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by AM0PR08MB5411.eurprd08.prod.outlook.com (2603:10a6:208:181::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Mon, 27 Jul 2026 14:53:26 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0245.012; Mon, 27 Jul 2026 14:53:25 +0000 Message-ID: <4ec1bc34-23db-4e96-b38f-03b7d26b2481@arm.com> Date: Mon, 27 Jul 2026 15:53:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/10] target_fileio_read_stralloc: add an optional length parameter To: Luis , gdb-patches@sourceware.org Cc: Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-4-matthieu.longo@arm.com> <89ed83ac-eff5-429d-abba-3d2a71cb7299@gmail.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <89ed83ac-eff5-429d-abba-3d2a71cb7299@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0119.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::16) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|AM0PR08MB5411:EE_|AMS0EPF000001B1:EE_|PA6PR08MB10470:EE_ X-MS-Office365-Filtering-Correlation-Id: 41fc7df9-25b7-44a6-b76a-08deebeef5a6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|1800799024|23010399003|376014|3023799007|10067099003|11063799006|56012099006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: q411i9Mxnoxr5ksq4xMRR2Pf3F6O2M8I3dk7RVpukAXx0s7VU2KQhCiuNn2GCoxSofAb3rp8K3IKHV9tyHC4l1WZDN05LGFxpzYssMcBo2Ksh21p9ltL43BVPg8c2dDguTT9KhQ9VC5ZfgjkYFeArNXIL4Fi4DATFfeCJ5TuS1+vaoUarzpL4iRD9MToFDeysHm7H6lokLkfzTHfkBiJBTtq99XhXn4+ET5xCCQI68r2oLq9EMka8t42p4M3rKyrqE2VtDkW27sGCUnaFax10BmMCNAX2zP2EXcvwO1VfNTwJSeTg4t40a+D1r57eFN0xLMVI8+VgV9cWrdtTLbnV9vw3FgVWM+FaBmOK5W+lmlINJymeXmbzfZX4asXGjfYP9OTOzmSq+9+yJN8pMVXOnmv/5Qi/RRMFaQPG/MPC0hh6iq8fXOXIj7O2nNEy3BTWzIcV8XPwt0hyi6PoyKZ36DzbHrxyPdWVdhtK76VzYnrKdBSYqEXuX00YtYgJ47NafOJ68T5qMl67FBLZpLjm0r1tk755SC31Od5NIwdBQsh1ZKwZlxJsrDLnYRtu+ahHpALkRUd6rCGDaXfud8UjGu9SOlpDSx+TImRRt5BaWr0A+xtbOD/g0dQG9E3NXvqqhif5Bbk4X9QzWKIo4aETN051kNdo+SN8LDEA9jIKWM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(3023799007)(10067099003)(11063799006)(56012099006)(4143699003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: IuP0xw5FziNAxPybgkigzGT//dDZnKBYQuKLNuOWisLsZf6crGxAi8WoaBPhWYppG3gntOrY33RrPli+OgALyJcTgGs1RfYnGjzjIbJr6bBs74g/mw1mbR38Nkd5LDZ660vQQUOEDmoPkiTfWRw1YzWb2c3jHJAgy6uB9RPxFhi170IGgFvd1t+RhF3EbXKbocaOuIU5i2I8CYCUqh850mcxMYYyD8QCBYMQqaSxi3olQhCknD65jrqYZATJYZw1D1Q/JbVVfZ4biYvoiq7PpRMcBHFIDdRH89m/8tjdepnYlS0dliVpvHe9hjE138c1pQQhfIyhS3F3SdJVQmR8Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5411 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001B1.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1cb3d5e6-1536-4dfc-be4a-08deebeecff4 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|23010399003|35042699022|36860700016|14060799003|376014|4143699003|11063799006|56012099006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: EvsM3/9dkqRRTdzYmkJMy2hnivqYW+S9QxBcxue330bUgdNWh433MOPvJbMAxNE2rnlcBpbLXvPXPuhoNFq6U8iNe5KLPckY9EHRUqspgsNwGABnytu5ZEvRdDmyblPuRBw+QjMPykcD468kWsyerafeT/4mi028G/Anbk2moLWNi17EIJnUbNlfu8tazgdIurl98apAvyflSxuId0OO9rUYw8qtRLTfKQ8u1bZOFS53zEV6lT3Cm/fY8A1XuFZgAzb0TRBNqXQP3XYr+NnMIF/WTcxf5DF5Q9EYX0vsnjwhjq9gOKo3vFlKe7fDikBkJLOExNfq1JIE7B1gLlI6CROBvKzhUoq1RsfEyR8UujmNvEoibuLJVkjXDZ12LPP9k4K3CTeZewl4ePgAnUNbusheWa+qgS+Gjt04Za5uzn+Iu0vbWvZc/kKF30CKKkUoaIIlBfKdwJ+G9m8FE7ikTOdZht1iINPHbPvYkyoA6mnvHklpDqnjEBK7Qj5DtqpNQ3upz1gLU3e9YaEC+ptpUJDW0Mp7rV/AXx9jOZum7tahoT/ODHEi1/DrBnIXb4a6U/13LJGww+TWXwl0d+X+FSht39e3E9twzt0sTqVrDOPIOVlo7wl9EeMUDnoXMKlkJxxeUUGXh4SLXN56cwM1PUxfQYcpN9xtSCbBQ/wSalQ62fgDPnPsFR7DAfgN4N+foDLxDIo7o1ILzVI4b3rvGA== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(23010399003)(35042699022)(36860700016)(14060799003)(376014)(4143699003)(11063799006)(56012099006)(10067099003)(3023799007)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2sVrBvtf7YHofy6SWmzK0ccO2NhjPUxWwfVWM9al0i7F0OEqfyZM3mHoRWw3NWXjzhUfxYEmbMIUgxeHtEnV+o6WACDGLi4AqXrx9ZvfREb1l488cNlmHjfcs2R6rppR0nVP1OiJ9jLmwoMlJWQNo605FxQ5Eu1WcXd3lgkmSNGcc30q+W4eKeTmemzOapWodI3se4NxY8oRVMUGoAj353prCSWMo25PVE+qoSqXSpX7plE4oFBZos5i8/MmGfFNcWFBZM3WDOg9CM3ur8hlvLpedM8QHNu11qPxPwqectoGww2EoR4KW5xMeozjoJvh6HBNIoY6rLrYRqRMbwHfzp8YXGV9kPZ3pRffP2dTHNEtTnHS3pZ2bcTrTq2XuOCMB2FfoOeolQfBkkBll5t4q1IDWlXBccQYuH+varzmDvyhIU5Fv6jEB54nmoNPzSrJ X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2026 14:54:28.8385 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41fc7df9-25b7-44a6-b76a-08deebeef5a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B1.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10470 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 21/07/2026 22:28, Luis wrote: > Empty commit message... Fixed in the next revision. target_fileio_read_stralloc: add an optional length parameter Extend target_fileio_read_stralloc with an optional output parameter that returns the number of bytes read, excluding the terminating NUL byte. Most callers only need the returned NUL-terminated buffer and can ignore the new parameter, but callers that need the number of bytes read can now obtain it without recomputing it. While updating the function, make a couple of minor cleanups by using '\0' instead of 0 for character literals and clarifying the function documentation.