Re: [RFA 23/23] Use gdb_argv_up in Python

Tom Tromey
2017-07-19T22:52:54Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> if (self->enumeration[i] == NULL)

Pedro> I think you need to adjust the if too:
Pedro> if (enumeration[i] == NULL)

Thanks, I made this fix.

>> + self->enumeration = const_cast<const char**> (enumeration.release ());

Pedro> If I'm reading the code correctly, "self->enumeration" is never
Pedro> released (by design), right?

Yes. I think it could be destroyed if the command is deleted, but I
can't remember now if that can happen; and anyway if it can it must be a
weird thing to do.

Tom