From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21515 invoked by alias); 18 Oct 2016 10:51:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21485 invoked by uid 89); 18 Oct 2016 10:51:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1608, parenthesis, worded, emails X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Oct 2016 10:51:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE793550B2; Tue, 18 Oct 2016 10:51:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9IApDd6019365; Tue, 18 Oct 2016 06:51:14 -0400 Subject: Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods To: Tom Tromey References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-17-git-send-email-tom@tromey.com> <94f5892b-e4d2-f903-36e2-513e37f3947b@redhat.com> <878ttmid6e.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4e861038-bc8a-6667-9a11-6c37e7ed4489@redhat.com> Date: Tue, 18 Oct 2016 10:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <878ttmid6e.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00507.txt.bz2 On 10/18/2016 03:49 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> - result = (this->funcs->get_addr_index) (this->baton, uoffset); >>> + result = (this->get_addr_index) (uoffset); > > Pedro> Should we remove the parens throughout? > > I made this change. > >>> + /* Push on DWARF stack an entry evaluated for DW_TAG_GNU_call_site's >>> + parameter matching KIND and KIND_U at the caller of specified BATON. >>> + If DEREF_SIZE is not -1 then use DW_AT_GNU_call_site_data_value >>> instead of >>> + DW_AT_GNU_call_site_value. */ >>> + virtual void push_dwarf_reg_entry_value (enum >>> call_site_parameter_kind kind, >>> + union call_site_parameter_u kind_u, >>> + int deref_size) >>> + { >>> + internal_error (__FILE__, __LINE__, >>> + _("Support for DW_OP_GNU_entry_value is unimplemented")); > > Pedro> Hmm, I think you may have missed my comments to this patch in v1. > > All I saw was the comment about possibly reducing churn: > > https://sourceware.org/ml/gdb-patches/2016-10/msg00208.html I'm sorry, I had written comments about the parenthesis thing and also about wondering whether these methods with internal_error could be pure virtual ('= 0;') instead, and if not, about adding a small comment mentioning it. I sometimes write reviews of separate chunks in separate emails in then merge it all before sending. Guess I deleted that email by mistake. > > ... but the way that was worded, I thought it didn't need any changes. Yeah, the churn thing is fine with me here. Thanks, Pedro Alves