From: Nick Clifton <nickc@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>,
binutils@sourceware.org, Saagar Jha <saagar@saagarjha.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use new Darwin operating system names
Date: Fri, 15 Feb 2019 10:02:00 -0000 [thread overview]
Message-ID: <4e4b1e4e-57b9-c754-9e49-55c9ad8e1812@redhat.com> (raw)
In-Reply-To: <20190214191325.2354ddbc@f29-4.lan>
Hi Saagar,
>
> 1) This entry should go in include/ChangeLog, so you don't need to
> have the include/ prefix.
>
> 2) Please adjust it to indicate that only the comments are affected.
> Like this, perhaps:
>
> * mach-o/loader.h: Use new OS names in comments.
>
> Otherwise, it looks good to me.
>
> I wish I could tell you to check this in, but I think that the
> binutils maintainers will need to approve this change. I've added
> binutils@sourceware.org to the "To:" header in my reply.
It is fine with the binutils too. So please apply with the changes
that Kevin has outlined.
Cheers
Nick
next prev parent reply other threads:[~2019-02-15 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 4:57 Saagar Jha
2019-02-15 2:13 ` Kevin Buettner
2019-02-15 10:02 ` Nick Clifton [this message]
2019-02-15 10:49 ` Saagar Jha
2019-02-15 12:52 ` Nick Clifton
2018-10-28 3:57 Saagar Jha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4b1e4e-57b9-c754-9e49-55c9ad8e1812@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=saagar@saagarjha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox