From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117478 invoked by alias); 28 Jun 2016 18:26:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117464 invoked by uid 89); 28 Jun 2016 18:26:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=cope, tui, mass X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jun 2016 18:26:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9C2715555; Tue, 28 Jun 2016 18:26:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5SIQfWC018328; Tue, 28 Jun 2016 14:26:42 -0400 Subject: Re: [RFA 2/6] Use ATTRIBUTE_UNUSED in some places To: Tom Tromey , gdb-patches@sourceware.org References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-3-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <4e0f2f7a-6363-271d-2d91-4f8352d6509f@redhat.com> Date: Tue, 28 Jun 2016 18:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465248812-23902-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00471.txt.bz2 On 06/06/2016 10:33 PM, Tom Tromey wrote: > A few spots needed ATTRIBUTE_UNUSED to cope with the new warnings. > > In the TUI this happens due to the odd way that "getyx" works -- it > essentially uses references, so a variable must be passed in, even if > the code doesn't need to use it. I think we should use getcurx/getcury instead. > > The case in inflow.c is just a mass of ifdefs; and while the only use > of "result" is guarded by "#if 0", I thought it simplest to leave it > all in place. > Agreed. Thanks, Pedro Alves