From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id N/V7LGtP1GfsVg8AWB0awg (envelope-from ) for ; Fri, 14 Mar 2025 11:46:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IqG9cHgt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a/8XulVZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IqG9cHgt; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a/8XulVZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A73391E105; Fri, 14 Mar 2025 11:46:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A491E1E08E for ; Fri, 14 Mar 2025 11:46:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A5FC385770E for ; Fri, 14 Mar 2025 15:46:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A5FC385770E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IqG9cHgt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a/8XulVZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IqG9cHgt; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a/8XulVZ Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1465C3857710 for ; Fri, 14 Mar 2025 15:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1465C3857710 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1465C3857710 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741967174; cv=none; b=pCuQjPkkktoUt6pUNXKripiSE6KT1hkDlH/9Q/NqYJVCpFbkneyjShSe4SpHyZzjBQOQEsW3l9ADKTKO+Lh7O348l55TLBb+wfM5Tm/8Q/fz51Q89PbBaKmwwlTM3ihHEN1COQlrUy/zkGqQhTciyaZccrGL+HdhIOx3Obo2tKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741967174; c=relaxed/simple; bh=dcqAk0P+u99uAP4/2i5Eh2NSvKedt6kGfNkbgJWW3MI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=sRkObIEqzK3mEr2vK14jp5j7n/Uc55Ok/b9G/hz0NdTLOJCR4L3EcPMUaSiTY1x0ipeHP+qIGXSp8dL0Smpfvc2OuIe5v1cUoby+9jYXgthfdw462TXbVau5Gg8xxW7wUz7U13lpetihHAGhxjjqajS4BPcfSagtI8SwlYleSuw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1465C3857710 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 061EF2118D; Fri, 14 Mar 2025 15:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741967173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7p2qeeliQjhXs7IfFY9D9/aUmn1UpnqI0P8lRVLnpTQ=; b=IqG9cHgtZ4hrzwwxL7MToZXmpF01z2RKp8HDjwkEQt+o2Hm6D0d7SLr4avZheSYRS2Twrs lDEO1zjbIkJ9uiTdYMezbuDmcddNfVlscCduG+0TJ6dwgHpY9QpUwTamygEHSNW3Qcxth0 kXD9VsbfO3TDWS5vfOn7KBeq0NooslA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741967173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7p2qeeliQjhXs7IfFY9D9/aUmn1UpnqI0P8lRVLnpTQ=; b=a/8XulVZ8VF2LR5Jp/0YxsNoto85Y1v0mdSsJewjkH3PaTnEA/cPtuEtUCU2S552QXVO41 ToIw0xbuiG3OoBDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IqG9cHgt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="a/8XulVZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741967173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7p2qeeliQjhXs7IfFY9D9/aUmn1UpnqI0P8lRVLnpTQ=; b=IqG9cHgtZ4hrzwwxL7MToZXmpF01z2RKp8HDjwkEQt+o2Hm6D0d7SLr4avZheSYRS2Twrs lDEO1zjbIkJ9uiTdYMezbuDmcddNfVlscCduG+0TJ6dwgHpY9QpUwTamygEHSNW3Qcxth0 kXD9VsbfO3TDWS5vfOn7KBeq0NooslA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741967173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7p2qeeliQjhXs7IfFY9D9/aUmn1UpnqI0P8lRVLnpTQ=; b=a/8XulVZ8VF2LR5Jp/0YxsNoto85Y1v0mdSsJewjkH3PaTnEA/cPtuEtUCU2S552QXVO41 ToIw0xbuiG3OoBDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D973713A31; Fri, 14 Mar 2025 15:46:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 68y0M0RP1GctTwAAD6G6ig (envelope-from ); Fri, 14 Mar 2025 15:46:12 +0000 Message-ID: <4e0a3406-0842-4d23-b8d7-53f995a273fa@suse.de> Date: Fri, 14 Mar 2025 16:46:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Backport i386_canonicalize_syscall rewrite to gdb-16-branch To: Andrew Burgess , gdb-patches@sourceware.org, Guinevere Larsen References: <20250313095325.23876-1-tdevries@suse.de> <87frjhx8zz.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87frjhx8zz.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 061EF2118D X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/13/25 16:09, Andrew Burgess wrote: > Tom de Vries writes: > >> Commit fbfb29b304e ("[gdb/tdep] Rewrite i386_canonicalize_syscall") fixes >> PR32770, which reproduces on the gdb-16-branch, but the commit is not ideal >> for backporting because it completely rewrites i386_canonicalize_syscall. >> >> Instead, this is a version of the patch that adds a single line entry for each >> syscall value for which i386_canonicalize_syscall gives a different result >> with and without the patch. >> >> Consequently, the two versions give identical results. I've checked this for >> syscalls 0 to 466. > > Given you've shown that this is equivalent to the version in > fbfb29b304e, and having taken a look at that commit, I'd be just as > happy to see that commit merged into the gdb-16-branch. The patch isn't > small, but equally, it's pretty contained and straight forward, so I > don't see huge risk there. > > But if you're happier with this approach in the gdb-16-branch, that's > fine with me. > Hi Andrew, thanks for the review. Gwen, do you have a preference? If not, given Andrew's assessment, I'll pick the patch from master rather than this one. Thanks, - Tom > Approved-By: Andrew Burgess > > Thanks, > Andrew > > >> >> Tested on x86_64-linux with target board unix/-m32, on top of gdb-16-branch. >> >> PR tdep/32770 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32770 >