From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8F8/EWDRx19ncQAAWB0awg (envelope-from ) for ; Wed, 02 Dec 2020 12:39:44 -0500 Received: by simark.ca (Postfix, from userid 112) id 4142A1F0AB; Wed, 2 Dec 2020 12:39:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABD781E58E for ; Wed, 2 Dec 2020 12:39:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7261395CCCB; Wed, 2 Dec 2020 17:39:41 +0000 (GMT) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 9CD9F395BC03 for ; Wed, 2 Dec 2020 17:39:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9CD9F395BC03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x341.google.com with SMTP id x22so9482788wmc.5 for ; Wed, 02 Dec 2020 09:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qUTR720oicWjQZSmfetLjNAWrojqvMGjZZCyM6GJ5eU=; b=CcPtyc5YNv1elFvlrji6Mo8tYvHMRZ7UOxajOdiEolpQ9G3+DQFGIeiAFbMhoiE8v8 TQd0q+ZhLz5UNY+QvUqN7SxxfJ4sJUoEpY1fAgvk+4VynI/4v7iDMpTKwMpHNUiGeV+B BeH9PaZtSxU7NM2xJpd619ark4sib71+ebWOxXv0r5IPi9JSD1AQXcHSBqM7VhuRtXzX GN1UTCX4+oVArthLbfBSUKLmkQKT5hHq4e2zsOhd/vqk/tfNjr/Ysz5XppF3dt7zF34X OuCB6rN7tSU+YrqRufjbSe7LVnJ8FPUQTH6d24w0NZYsy7gbS6FQmomTii8FlLfVv4M1 69DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qUTR720oicWjQZSmfetLjNAWrojqvMGjZZCyM6GJ5eU=; b=HXfSjZz0ok4XAHlKvcQ5DdE3984L+d7fKci2B0FKPbzGeBQE1SfwlMsnvaRPmqhuCL uHuJ9xjVORx+zxcd4UyjGoHgKnikZ9GjySJtwfuJpejvTXLlhk09fsz5lu//JvJ9t5jf U0orM0imj77+EISG5YfJNDzu0zrbRBP7QfuhCBmdiimCk7LqnvlE+L8/T1ADHuXMl5en UyPN592S+lTFmV6UGk8dvIutHf9Yd481ouDFiovS4S3ioq8wQevi/VlI7GDP0/7h/GvM DU0+uiJwPgHYrGVZ02V6y5kyMPNzrz4W4KJhyI9POETq8kRoariqjUztm2VPILIDi0k6 0BHQ== X-Gm-Message-State: AOAM531QDKdWnwZPUGVczUdpCLhc7H8AmR+rQWcsjuGULWG4KWJ0nP3I gzZJcTUWsyRw+Gyqj1GydJw06Q== X-Google-Smtp-Source: ABdhPJx03lol9bFUWZ3PPMvKdB6qXBqUvl9TDpm9LqN046SfDx+YNyZQBOtqBdk5McvJRCZcGdkJAw== X-Received: by 2002:a1c:67c2:: with SMTP id b185mr4152966wmc.119.1606930777711; Wed, 02 Dec 2020 09:39:37 -0800 (PST) Received: from localhost (host109-154-20-215.range109-154.btcentralplus.com. [109.154.20.215]) by smtp.gmail.com with ESMTPSA id q25sm3189460wmq.37.2020.12.02.09.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 09:39:37 -0800 (PST) From: Andrew Burgess To: binutils@sourceware.org, gdb-patches@sourceware.org Subject: [PATCH 2/8] bfd/binutils: support for gdb target descriptions in the core file Date: Wed, 2 Dec 2020 17:39:26 +0000 Message-Id: <4e0141d22b4b5bbf56e42d037f03f82485cf5bc4.1606930261.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This commit lays the ground work for allowing GDB to write its target description into a generated core file. The goal of this work is to allow a user to connect to a remote target, capture a core file from within GDB, then pass the executable and core file to another user and have the user be able to examine the state of the machine without needing to connect to a running target. Different remote targets can have different register sets and this information is communicated from the target to GDB in the target description. It is possible for a user to extract the target description from GDB and pass this along with the core file so that when the core file is used the target description can be fed back into GDB, however this is not a great user experience. It would be nicer, I think, if GDB could write the target description directly into the core file, and then make use of this description when loading a core file. This commit performs the binutils/bfd side of this task, adding the boiler plate functions to access the target description from within a core file note, and reserving a new number for a note containing the target description. Later commits will extend GDB to make use of this. bfd/ChangeLog: * elf-bfd.h (elfcore_write_gdb_tdesc): Declare new function. * elf.c (elfcore_grok_gdb_tdesc): New function. (elfcore_grok_note): Handle NT_GDB_TDESC. (elfcore_write_gdb_tdesc): New function. (elfcore_write_register_note): Handle NT_GDB_TDESC. binutils/ChangeLog: * readelf.c (get_note_type): Handle NT_GDB_TDESC. include/ChangeLog: * elf/common.h (NT_GDB_TDESC): Define. --- bfd/ChangeLog | 9 +++++++++ bfd/elf-bfd.h | 2 ++ bfd/elf.c | 23 +++++++++++++++++++++++ binutils/ChangeLog | 5 +++++ binutils/readelf.c | 2 ++ include/ChangeLog | 5 +++++ include/elf/common.h | 2 ++ 7 files changed, 48 insertions(+) diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h index e9c890f6f16..5ef69ab5b13 100644 --- a/bfd/elf-bfd.h +++ b/bfd/elf-bfd.h @@ -2796,6 +2796,8 @@ extern char *elfcore_write_aarch_pauth (bfd *, char *, int *, const void *, int); extern char *elfcore_write_arc_v2 (bfd *, char *, int *, const void *, int); +extern char *elfcore_write_gdb_tdesc + (bfd *, char *, int *, const void *, int); extern char *elfcore_write_lwpstatus (bfd *, char *, int *, long, int, const void *); extern char *elfcore_write_register_note diff --git a/bfd/elf.c b/bfd/elf.c index 419c5f4420c..bea5ab12773 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -9909,6 +9909,12 @@ elfcore_grok_arc_v2 (bfd *abfd, Elf_Internal_Note *note) return elfcore_make_note_pseudosection (abfd, ".reg-arc-v2", note); } +static bfd_boolean +elfcore_grok_gdb_tdesc (bfd *abfd, Elf_Internal_Note *note) +{ + return elfcore_make_note_pseudosection (abfd, ".gdb-tdesc", note); +} + #if defined (HAVE_PRPSINFO_T) typedef prpsinfo_t elfcore_psinfo_t; #if defined (HAVE_PRPSINFO32_T) /* Sparc64 cross Sparc32 */ @@ -10566,6 +10572,9 @@ elfcore_grok_note (bfd *abfd, Elf_Internal_Note *note) else return TRUE; + case NT_GDB_TDESC: + return elfcore_grok_gdb_tdesc (abfd, note); + case NT_PRPSINFO: case NT_PSINFO: if (bed->elf_backend_grok_psinfo) @@ -11947,6 +11956,18 @@ elfcore_write_arc_v2 (bfd *abfd, note_name, NT_ARC_V2, arc_v2, size); } +char * +elfcore_write_gdb_tdesc (bfd *abfd, + char *buf, + int *bufsiz, + const void *tdesc, + int size) +{ + const char *note_name = "CORE"; + return elfcore_write_note (abfd, buf, bufsiz, + note_name, NT_GDB_TDESC, tdesc, size); +} + char * elfcore_write_register_note (bfd *abfd, char *buf, @@ -12031,6 +12052,8 @@ elfcore_write_register_note (bfd *abfd, return elfcore_write_aarch_pauth (abfd, buf, bufsiz, data, size); if (strcmp (section, ".reg-arc-v2") == 0) return elfcore_write_arc_v2 (abfd, buf, bufsiz, data, size); + if (strcmp (section, ".gdb-tdesc") == 0) + return elfcore_write_gdb_tdesc (abfd, buf, bufsiz, data, size); return NULL; } diff --git a/binutils/readelf.c b/binutils/readelf.c index 57e0f1de459..5b3871d3e5f 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -18246,6 +18246,8 @@ get_note_type (Filedata * filedata, unsigned e_type) return _("NT_PRPSINFO (prpsinfo structure)"); case NT_TASKSTRUCT: return _("NT_TASKSTRUCT (task structure)"); + case NT_GDB_TDESC: + return _("NT_GDB_TDESC (GDB XML target description)"); case NT_PRXFPREG: return _("NT_PRXFPREG (user_xfpregs structure)"); case NT_PPC_VMX: diff --git a/include/elf/common.h b/include/elf/common.h index 95a852f0cf5..1dbf0b11983 100644 --- a/include/elf/common.h +++ b/include/elf/common.h @@ -666,6 +666,8 @@ #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ #define NT_FILE 0x46494c45 /* Description of mapped files. */ +#define NT_GDB_TDESC 0x54444553 /* Contains copy of GDB's target description XML. */ + /* Note segments for core files on dir-style procfs systems. */ #define NT_PSTATUS 10 /* Has a struct pstatus */ -- 2.25.4