Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: [PATCH v3 5/5] sim: Initialize pbb_br_* by default
Date: Thu,  6 Oct 2022 06:43:53 +0000	[thread overview]
Message-ID: <4de0f4c9f1074572c9a3a610c527fa0d4b047738.1665038297.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1665038297.git.research_trasio@irq.a4lg.com>

On the files generated by sim/common/genmloop.sh, variables pbb_br_type and
pbb_br_npc are declared uninitialized and passed to other functions in some
cases.  Despite that those are harmless, they will generate GCC warnings
("-Wmaybe-uninitialized").

This commit ensures that pbb_br_type and pbb_br_npc variables are
initialized to a harmless value.
---
 sim/common/genmloop.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sim/common/genmloop.sh b/sim/common/genmloop.sh
index 1bbeb615b05..5f6456d7159 100755
--- a/sim/common/genmloop.sh
+++ b/sim/common/genmloop.sh
@@ -1167,8 +1167,8 @@ void
   SEM_PC vpc;
 #if WITH_SEM_SWITCH_FULL
   /* For communication between cti's and cti-chain.  */
-  SEM_BRANCH_TYPE pbb_br_type;
-  PCADDR pbb_br_npc;
+  SEM_BRANCH_TYPE pbb_br_type = SEM_BRANCH_UNTAKEN;
+  PCADDR pbb_br_npc = 0;
 #endif
 
 EOF
@@ -1259,8 +1259,8 @@ void
   SEM_PC vpc;
 #if WITH_SEM_SWITCH_FAST
   /* For communication between cti's and cti-chain.  */
-  SEM_BRANCH_TYPE pbb_br_type;
-  PCADDR pbb_br_npc;
+  SEM_BRANCH_TYPE pbb_br_type = SEM_BRANCH_UNTAKEN;
+  PCADDR pbb_br_npc = 0;
 #endif
 
 EOF
-- 
2.34.1


  parent reply	other threads:[~2022-10-06  6:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 12:57 [PATCH 0/4] sim/common: Suppress warnings if built with Clang Tsukasa OI via Gdb-patches
2022-09-13 12:57 ` [PATCH 1/4] sim: Add ATTRIBUTE_PRINTF Tsukasa OI via Gdb-patches
2022-09-13 12:57 ` [PATCH 2/4] sim: Remove self-assignments Tsukasa OI via Gdb-patches
2022-09-13 12:57 ` [PATCH 3/4] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI via Gdb-patches
2022-10-05 11:38   ` Andrew Burgess via Gdb-patches
2022-10-06  5:33     ` Tsukasa OI via Gdb-patches
2022-09-13 12:57 ` [PATCH 4/4] sim: Suppress non-literal printf warning Tsukasa OI via Gdb-patches
2022-10-05 11:45   ` Andrew Burgess via Gdb-patches
2022-10-06  5:39     ` Tsukasa OI via Gdb-patches
2022-10-23 12:22       ` Mike Frysinger via Gdb-patches
2022-10-24 10:50         ` Tsukasa OI via Gdb-patches
2022-09-25  8:42 ` [PATCH v2 0/5] sim: Suppress warnings if built with Clang Tsukasa OI via Gdb-patches
2022-09-25  8:42   ` [PATCH v2 1/5] sim: Remove self-assignments Tsukasa OI via Gdb-patches
2022-09-25  8:42   ` [PATCH v2 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI via Gdb-patches
2022-09-25  8:42   ` [PATCH v2 3/5] sim: Suppress non-literal printf warning Tsukasa OI via Gdb-patches
2022-09-25  8:42   ` [PATCH v2 4/5] sim: Check known getopt definition existence Tsukasa OI via Gdb-patches
2022-09-25  8:42   ` [PATCH v2 5/5] sim: Initialize pbb_br_* by default Tsukasa OI via Gdb-patches
2022-10-06  6:43   ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Tsukasa OI via Gdb-patches
2022-10-06  6:43     ` [PATCH v3 1/5] sim: Remove self-assignments Tsukasa OI via Gdb-patches
2022-10-11 14:21       ` Andrew Burgess via Gdb-patches
2022-10-11 14:29         ` Tsukasa OI via Gdb-patches
2022-10-06  6:43     ` [PATCH v3 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI via Gdb-patches
2022-10-06  6:43     ` [PATCH v3 3/5] sim: Suppress non-literal printf warning Tsukasa OI via Gdb-patches
2022-10-11 14:22       ` Andrew Burgess via Gdb-patches
2022-10-06  6:43     ` [PATCH v3 4/5] sim: Check known getopt definition existence Tsukasa OI via Gdb-patches
2022-10-12 16:28       ` Tom de Vries via Gdb-patches
2022-10-12 17:03         ` Tsukasa OI via Gdb-patches
2022-10-12 17:08           ` Tom de Vries via Gdb-patches
2022-10-12 17:20             ` Tom de Vries via Gdb-patches
2022-10-13  9:50         ` Tsukasa OI via Gdb-patches
2022-10-23 12:16       ` Mike Frysinger via Gdb-patches
2022-10-27  2:02         ` Tsukasa OI via Gdb-patches
2023-01-03  3:12           ` Mike Frysinger via Gdb-patches
2023-01-03  8:47             ` Tsukasa OI via Gdb-patches
2022-10-06  6:43     ` Tsukasa OI via Gdb-patches [this message]
2022-10-11 14:20     ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Andrew Burgess via Gdb-patches
2022-10-11 16:40     ` Tom de Vries via Gdb-patches
2022-10-11 18:02       ` Tsukasa OI via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4de0f4c9f1074572c9a3a610c527fa0d4b047738.1665038297.git.research_trasio@irq.a4lg.com \
    --to=gdb-patches@sourceware.org \
    --cc=aburgess@redhat.com \
    --cc=research_trasio@irq.a4lg.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox