From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117585 invoked by alias); 12 Apr 2017 11:19:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117561 invoked by uid 89); 12 Apr 2017 11:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=inversion X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 11:19:55 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0F7CC059747; Wed, 12 Apr 2017 11:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F0F7CC059747 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F0F7CC059747 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 584611823D; Wed, 12 Apr 2017 11:19:55 +0000 (UTC) Subject: Re: [RFA v2 06/17] Remove cleanup_iconv To: Tom Tromey , gdb-patches@sourceware.org References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-7-tom@tromey.com> From: Pedro Alves Message-ID: <4dc59bfe-8129-03c6-4e47-0c246986f388@redhat.com> Date: Wed, 12 Apr 2017 11:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170411150112.23207-7-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00324.txt.bz2 On 04/11/2017 04:01 PM, Tom Tromey wrote: > + iconv_wrapper (const char *from, const char *to) > + { > + m_desc = iconv_open (to, from); ... > - desc = iconv_open (to, from); > - if (desc == (iconv_t) -1) > - perror_with_name (_("Converting character sets")); > - cleanups = make_cleanup (cleanup_iconv, &desc); > + iconv_wrapper desc (from, to); > I find the inversion of the order of "from" and "to" potentially confusing/misleading, given this is a "wrapper" class. Is there a rationale behind the swap? Thanks, Pedro Alves