From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1018 invoked by alias); 2 Jun 2016 09:08:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1001 invoked by uid 89); 2 Jun 2016 09:08:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL autolearn=no version=3.3.2 spammy=HContent-Language:de-DE, H*MI:local, H*r:15.0.1178.4, H*RU:15.0.1178.4 X-HELO: mx-relay23.cloudservice.ag Received: from mx-relay23.cloudservice.ag (HELO mx-relay23.cloudservice.ag) (46.235.240.137) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jun 2016 09:08:38 +0000 Received: from fw1.hostedoffice.ag ([81.20.90.82]) by mx-relay23.cloudservice.ag; Thu, 02 Jun 2016 11:08:34 +0200 Received: from EX132MBOX2A.de2.local (fw3.hostedoffice.ag [46.235.240.122]) by qhexrelay2.hosting.inetserver.de (Postfix) with ESMTP id 307861873FC for ; Thu, 2 Jun 2016 11:08:33 +0200 (CEST) Received: from EX132MBOX2B.de2.local (10.50.10.182) by EX132MBOX2A.de2.local (10.50.10.181) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Thu, 2 Jun 2016 11:08:33 +0200 Received: from EX132MBOX2B.de2.local ([fe80::d834:1170:aec:b5fa]) by EX132MBOX2B.de2.local ([fe80::d834:1170:aec:b5fa%19]) with mapi id 15.00.1178.000; Thu, 2 Jun 2016 11:08:33 +0200 From: =?iso-8859-1?Q?V=F6rtler=2C_Thilo?= To: "gdb-patches@sourceware.org" Subject: [RFC][PATCH] - Fix pretty-printers which call the inferiors, mi-interface crashs Date: Thu, 02 Jun 2016 09:08:00 -0000 Message-ID: <4db0b84bba2d4a208b37bd6edbc4152d@EX132MBOX2B.de2.local> x-ms-exchange-transport-fromentityheader: Hosted x-exclaimer-md-config: 2329e0da-e5c9-454a-b62b-9269baa51382 x-hoag-tnef: done Content-Type: multipart/mixed; boundary="_002_4db0b84bba2d4a208b37bd6edbc4152dEX132MBOX2Bde2local_" MIME-Version: 1.0 X-cloud-security-sender:thilo.voertler@coseda-tech.com X-cloud-security-recipient:gdb-patches@sourceware.org X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay23.cloudservice.ag with 474BD1120C07 X-cloud-security-connect: fw1.hostedoffice.ag[81.20.90.82], TLS=0, IP=81.20.90.82 X-cloud-security:scantime:.2846 X-SW-Source: 2016-06/txt/msg00023.txt.bz2 --_002_4db0b84bba2d4a208b37bd6edbc4152dEX132MBOX2Bde2local_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 761 Hi, as described in Bug 17437 the mi interface corrupts cached frames in the list_arg_or_local function of mi-cmd-stack.c when a pretty-printer calls a function of the inferior. To prevent this the frame_id is stored and used to restore the frame after calling list_arg_or_local - MI regressions were run and no effect through the patch was seen Is this patch okay? BR, Thilo gdb/ChangeLog: 2016-06-02 Thilo V=F6rtler * mi-cmd-stack.c (list_args_or_locals) the mi interface corrupts=20 cached frames in the list_arg_or_local function of mi-cmd-stack.c when a pretty-printer calls a function of the inferior. To prevent this the=20 frame_id is stored and used to restore the frame after calling=20 list_arg_or_local --_002_4db0b84bba2d4a208b37bd6edbc4152dEX132MBOX2Bde2local_ Content-Type: application/octet-stream; name="0001-FIX-pretty-printers-which-call-the-inferiors-though-.patch" Content-Description: 0001-FIX-pretty-printers-which-call-the-inferiors-though-.patch Content-Disposition: attachment; filename="0001-FIX-pretty-printers-which-call-the-inferiors-though-.patch"; size=1418; creation-date="Thu, 02 Jun 2016 08:22:03 GMT"; modification-date="Thu, 02 Jun 2016 08:22:03 GMT" Content-Transfer-Encoding: base64 Content-length: 1924 RnJvbSAxYmQ3M2E0YjM5ZmNiZTMxMzYyYzU3YTZkMmUwMzkyMDE4YTYyNDM1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/VGhp bG89MjBWPUMzPUI2cnRsZXI/PSA8dGhpbG8udm9lcnRsZXJAY29zZWRhLXRl Y2guY29tPgpEYXRlOiBXZWQsIDEgSnVuIDIwMTYgMTU6MTY6NTcgKzAyMDAK U3ViamVjdDogW1BBVENIXSBGSVggcHJldHR5LXByaW50ZXJzIHdoaWNoIGNh bGwgdGhlIGluZmVyaW9ycyB0aG91Z2ggdGhlIG1pLWludGVyZmFjZQoKLSBh cyBkZXNjcmliZWQgaW4gQnVnIDE3NDM3IHRoZSBtaSBpbnRlcmZhY2UgY29y cnVwdHMgY2FjaGVkIGZyYW1lcyBpbgp0aGUgbGlzdF9hcmdfb3JfbG9jYWwg ZnVuY3Rpb24gb2YgbWktY21kLXN0YWNrLmMgd2hlbiBhIHByZXR0eS1wcmlu dGVyCmNhbGxzIGEgZnVuY3Rpb24gb2YgdGhlIGluZmVyaW9yLiBUbyBwcmV2 ZW50IHRoaXMgdGhlIGZyYW1lX2lkIGlzIHN0b3JlZAphbmQgdXNlZCB0byBy ZXN0b3JlIHRoZSBmcmFtZSBhZnRlciBjYWxsaW5nIGxpc3RfYXJnX29yX2xv Y2FsCi0gTUkgcmVncmVzc2lvbnMgd2VyZSBydW4gYW5kIG5vIGVmZmVjdCB0 aHJvdWdoIHRoZSBwYXRjaCB3YXMgc2VlbgotLS0KIGdkYi9taS9taS1jbWQt c3RhY2suYyB8ICAgIDQgKysrKwogMSBmaWxlcyBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2RiL21p L21pLWNtZC1zdGFjay5jIGIvZ2RiL21pL21pLWNtZC1zdGFjay5jCmluZGV4 IDM5MGZjN2UuLjU2MjI4MzQgMTAwNjQ0Ci0tLSBhL2dkYi9taS9taS1jbWQt c3RhY2suYworKysgYi9nZGIvbWkvbWktY21kLXN0YWNrLmMKQEAgLTU4MSw4 ICs1ODEsMTAgQEAgbGlzdF9hcmdzX29yX2xvY2FscyAoZW51bSB3aGF0X3Rv X2xpc3Qgd2hhdCwgZW51bSBwcmludF92YWx1ZXMgdmFsdWVzLAogICBzdHJ1 Y3QgdHlwZSAqdHlwZTsKICAgY2hhciAqbmFtZV9vZl9yZXN1bHQ7CiAgIHN0 cnVjdCB1aV9vdXQgKnVpb3V0ID0gY3VycmVudF91aW91dDsKKyAgc3RydWN0 IGZyYW1lX2lkIGlkOwogCiAgIGJsb2NrID0gZ2V0X2ZyYW1lX2Jsb2NrIChm aSwgMCk7CisgIGlkID0gZ2V0X2ZyYW1lX2lkIChmaSk7CiAKICAgc3dpdGNo ICh3aGF0KQogICAgIHsKQEAgLTY4MCw2ICs2ODIsOCBAQCBsaXN0X2FyZ3Nf b3JfbG9jYWxzIChlbnVtIHdoYXRfdG9fbGlzdCB3aGF0LCBlbnVtIHByaW50 X3ZhbHVlcyB2YWx1ZXMsCiAJCWxpc3RfYXJnX29yX2xvY2FsICgmZW50cnlh cmcsIHdoYXQsIHZhbHVlcywgc2tpcF91bmF2YWlsYWJsZSk7CiAJICAgICAg eGZyZWUgKGFyZy5lcnJvcik7CiAJICAgICAgeGZyZWUgKGVudHJ5YXJnLmVy cm9yKTsKKworCSAgICAgIGZpID0gZnJhbWVfZmluZF9ieV9pZChpZCk7CiAJ ICAgIH0KIAl9CiAKLS0gCjEuNy4xCgo= --_002_4db0b84bba2d4a208b37bd6edbc4152dEX132MBOX2Bde2local_--