From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jPOjKz+uw2rGxTwAWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 10:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1791209023; bh=9Z+k88TfnweHkLOLXbdTxpxzy1r1054hD1TKRJi0KyI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C8jgEciqtYKHTGVoQTfaDfPn2FuF+9COt9eJFHxFK4MQs5U/mbJn7K/IoVXWemdjW VMLqeGGScAl/ilJWgur68ziABSF8Q8OZhMttVQ+/mPv+nwU9wBM12bYLVxvYUd7F5+ EkGkRw/Ykf0pWsRFeLpxVD5lFsQ27+PMswJsEsCQ= Received: by simark.ca (Postfix, from userid 112) id 9AFBA1E051; Mon, 05 Oct 2026 10:03:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=FidXEvba; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E2F1A1E04E for ; Mon, 05 Oct 2026 10:03:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71C2E4BA9030 for ; Mon, 5 Oct 2026 14:03:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71C2E4BA9030 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=FidXEvba Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 071C44BA902E for ; Mon, 5 Oct 2026 14:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 071C44BA902E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 071C44BA902E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791208985; cv=none; b=IWLX7EEbDxQ3uMBACiYRzQN9u7ngOuOOx60VHvJvdMe3v+jZFTrHNJi7XTWsd2rqgD56FC57Bws6xtX61NF4XRWFm+Q0bxQf/c+imZwEoaFzcdesoM/rq4Poye+4XeOWxkN5vO92lemtcSWH68qye3qoMwNHnVWJVH2PruFdgIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791208985; c=relaxed/simple; bh=9Z+k88TfnweHkLOLXbdTxpxzy1r1054hD1TKRJi0KyI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LyC/OVHoCoYnhg84Lyqc8IhLx7O5Bso+pTXTY8VpM1pV+eeW2R1e8oz5wkY3HuQRUWy4stdxzw7yLCT/64rlbnWWGWMEQRfMKroj6nNq61erkiJfh1IVeblwJchxw+rsEru/Hfxl5aca8tD7ZLfMLH4Cxxly4ABZ0s3s9nYnKw0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=FidXEvba DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 071C44BA902E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1791208983; bh=9Z+k88TfnweHkLOLXbdTxpxzy1r1054hD1TKRJi0KyI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=FidXEvbaFSUyrxFYwILHwikk9ptcJGASydmHnivEpFvRDZ94WcV78nhPJG6H6DTtt SKvJupiharZxObzLDUY7PfBw5j9r37trwpHwrNHJCGXxs7c4I4mVpnPVQIFDCLctUP /CQ3gU1WLN2jjkxozBPnuAXVzC8rVI4fT4LkQf1k= Received: by simark.ca (Postfix) id 4E5401E04E; Mon, 05 Oct 2026 10:03:03 -0400 (EDT) Message-ID: <4da1ade7-98ec-4d80-94a3-079fe0bb72b4@simark.ca> Date: Mon, 5 Oct 2026 10:03:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: use with_timeout_factor in 2 more tests To: Jan Vrany , gdb-patches@sourceware.org References: <20261005095158.1186551-1-jan@vrany.io> Content-Language: fr From: Simon Marchi In-Reply-To: <20261005095158.1186551-1-jan@vrany.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/5/26 5:52 AM, Jan Vrany wrote: > When running tests on some really slow targets, I got timeout in > gdb.base/funcargs.exp and gdb.base/completion.exp. The usual remedy I > use is to set timeout to higher value in site.exp. I'd be curious to know which tests in those files exactly, see if we can improve either the test or GDB. > However this does not help in case of aforementioned tests because they > set timeout to fixed value, regardless of whether the timeout has been > increased or not, causing them to fail on some of my machines. > > This commit fixes the problem by using with_timeout_factor. > > Since with_timeout_factor wraps large chunks of code, I decided not > to reformat (indent) it to make the patch easier to read and to > avoid "noise" when git-blaming. I would suggest do the re-indent. I find readability of current code more important than hypothetic git-blamability. Plus, I believe that anyone doing any serious git-blaming should use a better tool than plain bit-blame, allowing to easily jump over uninteresting commits (for instance, I use "tig blame" and jumping over an uninteresting commit is one keystroke). > --- > gdb/testsuite/gdb.base/completion.exp | 6 +++++- > gdb/testsuite/gdb.base/funcargs.exp | 11 +++++++---- > 2 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp > index 44cf649d5b6..f145f084999 100644 > --- a/gdb/testsuite/gdb.base/completion.exp > +++ b/gdb/testsuite/gdb.base/completion.exp > @@ -61,7 +61,8 @@ if {![runto_main]} { > return > } > > -set timeout 30 > +with_timeout_factor 3 { > + > gdb_test_no_output "set max-completions unlimited" > > gdb_test_no_output "complete print values\[0\].x." \ > @@ -995,3 +996,6 @@ foreach_with_prefix spc { " " "" } { > } > } > } > + > +# end of with_timeout_factor > +} > diff --git a/gdb/testsuite/gdb.base/funcargs.exp b/gdb/testsuite/gdb.base/funcargs.exp > index fdfdf07b78c..dd3240ba5e0 100644 > --- a/gdb/testsuite/gdb.base/funcargs.exp > +++ b/gdb/testsuite/gdb.base/funcargs.exp > @@ -1031,13 +1031,15 @@ proc_with_prefix stepping_over_trampolines { } { > } > } > > -set prev_timeout $timeout > + > if {[istarget "mips*tx39-*"]} { > - set timeout 300 > + set timeout_factor 30 > } else { > - set timeout 60 > + set timeout_factor 6 > } I would suggest getting rid of this special "mips*tx39-*" case. LGTM with those fixed. Approved-By: Simon Marchi Simon