From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24027 invoked by alias); 28 May 2018 12:36:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24013 invoked by uid 89); 28 May 2018 12:36:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 May 2018 12:36:39 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 34800401EF04; Mon, 28 May 2018 12:36:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 697052166BB6; Mon, 28 May 2018 12:36:37 +0000 (UTC) Subject: Re: [PATCH] Do not clear the value of st_dev in File I/O's stat() To: Julio Guerra , Corinna Vinschen References: <20180517082631.26855-1-julio@farjump.io> <010201636d368a34-7edcde92-3661-4c9a-94b4-a894b9c8e90a-000000@eu-west-1.amazonses.com> <9445cc6c-a954-7cdf-d0dc-47a18e596db3@redhat.com> <20180528104153.GA3501@calimero.vinschen.de> <6f5980ae-247c-1991-ba3c-884fe04a94c5@farjump.io> <01020163a6b434b4-79b66ed1-e2f7-4333-b7cc-94986e13b161-000000@eu-west-1.amazonses.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <4d9faac3-9899-26b8-cc52-e045cbbad543@redhat.com> Date: Mon, 28 May 2018 13:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <01020163a6b434b4-79b66ed1-e2f7-4333-b7cc-94986e13b161-000000@eu-west-1.amazonses.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00733.txt.bz2 On 05/28/2018 01:23 PM, Julio Guerra wrote: > I think the approach is still valid, otherwise it would be like if the > target program should know the host. Which reminds me that with > remote_fileio_fstat(), I have the case where my host st_dev has 64 bits, > which doesn't fit into fileio's 32-bit fst_dev. > > I think I should resubmit this patch along with my other patch allowing > to "open non regular files" so that I add common device ids (link, fifo, > etc.) to the list of returned fst_dev, and I modify > remote_fileio_fstat() so that it applies the same values to fst_dev. Great, that sounds like the right direction. Thanks. And thanks Corinna. Thanks, Pedro Alves