From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id k1GpB1JVk2BdFAAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 22:32:50 -0400 Received: by simark.ca (Postfix, from userid 112) id 1243C1F11C; Wed, 5 May 2021 22:32:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7903E1E813 for ; Wed, 5 May 2021 22:32:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0612F3858022; Thu, 6 May 2021 02:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0612F3858022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620268369; bh=ge+kGb8C6iHaOpQrHE8xtOFWooae2WW6wsgef9BSVAQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mCFFKRw3u8R3EjUqfjmiCdE1xZwq50ion9qXlQmivrds2PlF+Qy7BF+Mo+4x4fGa7 z7S5AyCV3i3yRr1iAggPvikb9yPt4/h6wrW/VXnZYJWthXg4AZD2pgbnlUrh93Vrsi QzKdI1joZIuxaK+kXF2qaFYkJOWRHwRE6PuSRMqA= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 03F173858022 for ; Thu, 6 May 2021 02:32:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03F173858022 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1462WeZg019903 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 May 2021 22:32:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1462WeZg019903 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C79021E813; Wed, 5 May 2021 22:32:40 -0400 (EDT) Subject: Re: [PATCHv2 2/2] gdb/guile: Have gdbscm_safe_source_script return a unique_ptr To: Andrew Burgess , gdb-patches@sourceware.org References: <87bl9pq9li.fsf@tromey.com> <17720e44850a8a0ed172812da5ce6a3919f9bb4e.1620248278.git.andrew.burgess@embecosm.com> Message-ID: <4d2ff439-afdf-08d1-2ec2-a07d07a0739c@polymtl.ca> Date: Wed, 5 May 2021 22:32:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 6 May 2021 02:32:40 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-05 10:28 p.m., Simon Marchi via Gdb-patches wrote: > On 2021-05-05 5:01 p.m., Andrew Burgess wrote: >> diff --git a/gdb/guile/scm-safe-call.c b/gdb/guile/scm-safe-call.c >> index 5bea970239b..a475774f921 100644 >> --- a/gdb/guile/scm-safe-call.c >> +++ b/gdb/guile/scm-safe-call.c >> @@ -432,7 +432,7 @@ scscm_source_scheme_script (void *data) >> printed according to "set guile print-stack" and the result is an error >> message allocated with malloc, caller must free. */ >> >> -char * >> +gdb::unique_xmalloc_ptr >> gdbscm_safe_source_script (const char *filename) >> { >> /* scm_c_primitive_load_path only looks in %load-path for files with >> @@ -454,7 +454,7 @@ gdbscm_safe_source_script (const char *filename) >> (void *) filename); >> >> if (result != NULL) >> - return xstrdup (result); >> + return make_unique_xstrdup (result); >> return NULL; > > Hmm, result comes from gdbscm_with_guile, which states: > > The result if NULL if no exception occurred, otherwise it is a statically > allocated error message (caller must *not* free). */ Ahh, nevermind. I noticed now that it's "make_unique_xstrdup". I first read it as just creating a unique pointer to wrap result. LGTM then! Simon