From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RC/RGt290GoD7xAAWB0awg (envelope-from ) for ; Thu, 15 Oct 2026 07:49:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dRACgiEY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 445FA1E050; Thu, 15 Oct 2026 07:49:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCBB31E04E for ; Thu, 15 Oct 2026 07:49:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D86094BA23C5 for ; Thu, 15 Oct 2026 11:49:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D86094BA23C5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dRACgiEY Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A88724BA2E11 for ; Thu, 15 Oct 2026 11:49:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A88724BA2E11 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A88724BA2E11 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792064959; cv=none; b=pa202JG8lH2bidBriAtdjmpC73VXtT5MU5jCbV2vMjFg3oQ4lwU2bsa4X1QNpvne6T2/lsn4vBRS8XDDH83X4NTbQphahkARR3BgBg68DTzbGUQ4//j6GcWCxObi3+g0BHAZmiKi1srU7Hj1WRnVQdoXqlV+kHKTbPaPv6n5kWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792064959; c=relaxed/simple; bh=Ds+nX4MhmoV9L4S9Fe9bPaeNdNlaPpKV+NTlkQ/sZ/I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nBB/zaZU0/DbGpSwszEGDK2SCbsXhm/P/WpAhsrMjQzXvfP3teZnecaM8df4YYEy8ayJEOgze0hbthQ9u3qJFBgBGky2S//zM05s4RY/Sh2WMscj1TKBAem7qN2qRHOuhf5ktxc9ASm7EJTp43z8NqaJivBymVm8JaN3HEewNmE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dRACgiEY DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A88724BA2E11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792064958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RIjlJPFoJP2kPpTtr9rvGANLVk/bJ6PaICkQJYoYoqg=; b=dRACgiEY5189RKDekrbk0yewAhmBtp6Wx16lvfu9+R5/9Apwj8jaUyGvLv7K+1bxmvyXu/ C2KOp7P6uqYFW/iJJ/PFgiEF8LFRp56czT0b/My+HebO93zejnZL00tifKPv7AzhDgv6vv iDdsCzeNIgeyqJMWlB6wYj+OOCEVMd8= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-oF6IsOXTOECHwdIcDE5uaQ-1; Thu, 15 Oct 2026 11:49:17 +0000 X-MC-Unique: oF6IsOXTOECHwdIcDE5uaQ-1 X-Mimecast-MFC-AGG-ID: oF6IsOXTOECHwdIcDE5uaQ_1792064957 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5e96f90659eso555413e0c.1 for ; Thu, 15 Oct 2026 04:49:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792064957; x=1792669757; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RIjlJPFoJP2kPpTtr9rvGANLVk/bJ6PaICkQJYoYoqg=; b=zjryDJk7Kz9mjP0fV+DKTjwVmB+YNODHBFI1cMs0PclubYTMLt+Tss4AE54G6ToqZ3 O3WdhgOz6HSYYQJrRXEExAg4BD2hylRrz7WpA9NRNA91A1EmTGWoTnS/VQSZAXbGzcgK 44vetrTRQU76THc/u4KXU8vZzS0CFdwprcRetctPPUsZEhrqQI2vfLGAgdqE/+l71FuP mKDP1wI13JkLZ1E5hLhWio4YxAzqMosQosK5pGC9PQNP2FM1kiVULGIZSPGQLsiUG79i TIQNrTqO6pcjaHY7SP77tykEFgJpaPnV2ofvf7gj8WY849kjkN3uI1kDBkGFPfAXo/KR YMaw== X-Forwarded-Encrypted: i=1; AKwUvBwL2i6sxwKi2acSEQ4khP6D1BQVgZS3Uh9oY2trrHMIHXsTcbZcYbXRRbE8CWAQ3ukCdSHPRMa2E8c4lA==@sourceware.org X-Gm-Message-State: AFq9FYLn7NvfFcxtpb0712fRuGNW6Vy9YXzElf4vNeOzBa3DjxpP6ujQ tXcUNNXi2suOeqnirdbbuuBzxanrnji01YgFR0mT8AccWNpE3PeeOlEej607HDCtgCNAWNrCZCM BZkve8m7Iv8O3oGcHDO/ZvuB17nyrx8IbMmeQpuvq9E6fm0IiKdt4U9CPJbM4JLXv0EhFniU= X-Gm-Gg: AYBFou1BsWlKpsUSjxNMImQGnd7Jo90iNu3Hb05rZ/nkJKtCMfENychpSO6HdnW7Y8O Lw3trk0pBAvejodz63FdlnxaPrIj8CGv0jFl+Wc1tIhS4Eb7SRYaKo6FYKq/UYNsLLf4dKkkbCJ IQJ/BGmo1Bvc5oSNhJSCDW9tCbie/nYiuePsXWfHXZYrXSgyxnRx0FnbwIvr7B20DcbOFqVp1Av mZHbwPgd1VCZ8HAPFHIRPGS6D8eJmcKzJxyI++RPZNf3hhKEfl1AOqB7ATuylkE48blvvNmQTNi I2G0CfO2/irEOxtyuJ/lv+1qc0wKmu9p06a1vKesWUvvGAIesq9ugVbbVD/hkbhN16yCkUvRysg fvxTcxrhyldV4IrDEk/36LAJdMWPL+VpKz5CmJ9L4KpP7he+3 X-Received: by 2002:a05:6122:3906:b0:5c9:c60a:e9b6 with SMTP id 71dfb90a1353d-5e91f568fe2mr5217472e0c.22.1792064956887; Thu, 15 Oct 2026 04:49:16 -0700 (PDT) X-Received: by 2002:a05:6122:3906:b0:5c9:c60a:e9b6 with SMTP id 71dfb90a1353d-5e91f568fe2mr5217465e0c.22.1792064956399; Thu, 15 Oct 2026 04:49:16 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:22e8:4ed1:527a:55c0? ([2804:14d:8084:993e:22e8:4ed1:527a:55c0]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5e92f300f42sm11570350e0c.0.2026.10.15.04.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 04:49:15 -0700 (PDT) Message-ID: <4d285300-6bd0-4445-8b55-425a25e1c771@redhat.com> Date: Thu, 15 Oct 2026 08:49:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix assert after register write failure To: Stephan Rohr , gdb-patches@sourceware.org References: <20261012103813.112609-1-stephan.rohr@intel.com> From: Guinevere Larsen In-Reply-To: <20261012103813.112609-1-stephan.rohr@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: syKUrgXjMN32Z0F0aQ7MHhZgfY2119x13pFtae601Ms_1792064957 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/12/26 7:38 AM, Stephan Rohr wrote: > From: Eduard Sargsyan > > GDB tries to invalidate register cache if write to register fails. In case > when write was requested to be done for a remote inferior and connection with > remote is dead (so write request will fail) GDB cleans register caches and as > result setting register status fails with segmentation fault, because internal > pointers are not valid anymore and the unique_ptr with register status is > null. > > This change adds check if register status cache is still valid before trying to > modify (set status to UNKNOWN). > --- Hi! Thanks for working on this! I wonder if it would be better to move this check to regcache::invalidate instead, so that we don't need to make this check every time invalidate is called in this kind of situation. -- Cheers, Guinevere Larsen it/its she/her (deprecated) > gdb/regcache.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/gdb/regcache.c b/gdb/regcache.c > index 773e8ac37d0..01c60ea8047 100644 > --- a/gdb/regcache.c > +++ b/gdb/regcache.c > @@ -883,8 +883,11 @@ regcache::raw_write (int regnum, gdb::array_view src) > > /* Invalidate the register after it is written, in case of a > failure. */ > - auto invalidator > - = make_scope_exit ([&] { this->invalidate (regnum); }); > + auto invalidator = make_scope_exit ([&] > + { > + if (this->m_register_status != nullptr) > + this->invalidate (regnum); > + }); > > target_store_registers (this, regnum); >