From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123877 invoked by alias); 30 Nov 2016 22:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123801 invoked by uid 89); 30 Nov 2016 22:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=much X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 22:14:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 865466A6CE; Wed, 30 Nov 2016 22:14:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUMEr3J005424; Wed, 30 Nov 2016 17:14:53 -0500 Subject: Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple To: Luis Machado , gdb-patches@sourceware.org References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-8-git-send-email-lgustavo@codesourcery.com> <6d3d9103-a7dc-e788-d7cd-596f64b29f8d@redhat.com> From: Pedro Alves Message-ID: <4cf69faf-d581-2e9f-0db9-2081495760c9@redhat.com> Date: Wed, 30 Nov 2016 22:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg01030.txt.bz2 On 11/30/2016 09:05 PM, Luis Machado wrote: > gdb_test_no_output then? It doesn't check for any output other than the > prompt. '-re "$gdb_prompt $"' implicitly matches whatever might come before the prompt too, but yeah, that'd be better even, assuming the command doesn't output anything, which is probably true. OK with that change. > >> ? >> >> I'd end up fixing two extra things: >> >> - note the typo in the pass case: "unwiNN" >> - odd "(timeout)" print position. timeout handling it not necessary >> at all with gdb_test_multiple, even. > > I see more occurrences of expecting timeouts where they're not needed. > I'll fix in a follow-on patch. Thanks much! Thanks, Pedro Alves