From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100142 invoked by alias); 17 Nov 2016 16:57:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100129 invoked by uid 89); 17 Nov 2016 16:57:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1699, UD:readline.o, readline.o, readlineo X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 16:57:09 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E45BC3D48A; Thu, 17 Nov 2016 16:57:07 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAHGv69f011279; Thu, 17 Nov 2016 11:57:07 -0500 Subject: Re: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules To: Simon Marchi References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-4-simon.marchi@ericsson.com> <773f613d-7157-258e-bb1c-daf86a7ec0d3@redhat.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4c986744-5319-da22-0a1e-cb7edbd1dabd@redhat.com> Date: Thu, 17 Nov 2016 16:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00486.txt.bz2 On 11/17/2016 04:52 PM, Simon Marchi wrote: > On 2016-11-16 14:10, Pedro Alves wrote: >> IMO, whether to explicitly remove default suffixes from the >> the implicit rule suffixes list for efficiency is a separate >> subject, since we're not currently doing it either. >> >> Just to be sure none of the default suffix rules is necessary, >> can you confirm: >> >> 1. that "make -r" (from scratch) still works. > > "make -r" from scratch from the top-level fails in the readline directory: > > ar: readline.o: No such file or directory > > It seems like readline relies on implicit rules. It shouldn't be > affected by gdb disabling them though. I did a "make" in the readline > directory to make it build, then resume the top-level build with "make > -r", and it finished cleanly. > >> 2. that "make -r diststuff" in the gdb build dir still works. > > The commands completes successfully, so it looks good. Still, perhaps > Joel should be a little bit more careful when doing the next release to > make sure nothing it missing. > >> If the above work, then this is OK with me to push in. > > Just to be clear, this patchset does not disable the default suffix > rules, so I don't think it was really necessary to check that for this > patch. But at least we know it's safe for when we'll want to disable them. You've changed .pot etc. rules which aren't triggered by a normal build, so I wanted to be sure that they weren't now working after the patch just because we'd happen to pick the default rules instead of the new patterns. So I think it was useful testing. In any case, it works, so I'm happy. :-) Thanks, Pedro Alves