From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76992 invoked by alias); 13 May 2019 13:56:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76936 invoked by uid 89); 13 May 2019 13:56:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:816 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 May 2019 13:56:51 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x4DDuhPG023855 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 May 2019 09:56:48 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x4DDuhPG023855 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1557755809; bh=RSAKmdY63EQzRmoX0rwR20kAipHgwRd9fIIkcDzgN8I=; h=Subject:To:References:From:Date:In-Reply-To:From; b=fBSiSYWsuywFhVbsO0t3g4WOrJEQGTDc7ewU7Onkw/hIhkkvSbfDntidlzm4LagG+ uAJJ84v5ZnW9J7v4fkotala96C6SIDj6Y6+lJHDSfrZhhMYhxmwUqfwnbW9dgpVJxX yFUR51XBy61FM5wGGYmVLyZMev/h88nXIXFb1/II= Received: from [172.16.0.120] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A6D991E623; Mon, 13 May 2019 09:56:43 -0400 (EDT) Subject: Re: [PATCH][gdb] Write index for dwz -m file To: Tom de Vries , gdb-patches@sourceware.org References: <20190507144207.GA17626@delia> <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> From: Simon Marchi Message-ID: <4c7917b3-cdf0-0f17-ab6c-e76d891dfd3b@polymtl.ca> Date: Mon, 13 May 2019 13:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00298.txt.bz2 On 2019-05-13 8:22 a.m., Tom de Vries wrote: > On 11-05-19 04:36, Simon Marchi wrote: >> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile) >> >> if (debug_index_cache) >> printf_unfiltered ("index cache: writing index cache for objfile %s\n", >> - objfile_name (obj)); >> + objfile_name (obj)); >> >> /* Write the index itself to the directory, using the build id as the >> filename. */ > > LGTM. > > [ I'm not sure if this white-space-only change should be included though. ] > > Thanks, > - Tom Hmm probably not, but I am tempted to leave it in, since I am touching the lines around it (and it fixes the wrong indentation). I will leave this patch up for review for a week or so, to give the others a chance to comment. Simon