From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oPEUNEJt62lBwzgAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 09:16:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zjjBYyXF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=etPf5ue8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=arztqEzQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=XcYDh6Vm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C32881E0BA; Fri, 24 Apr 2026 09:16:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9192E1E067 for ; Fri, 24 Apr 2026 09:16:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EE9FA4BA2E0F for ; Fri, 24 Apr 2026 13:16:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE9FA4BA2E0F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zjjBYyXF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=etPf5ue8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=arztqEzQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=XcYDh6Vm Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id B12B44BABF19 for ; Fri, 24 Apr 2026 13:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B12B44BABF19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B12B44BABF19 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777036583; cv=none; b=I86LElLfkPwEiPpWLGosciIq9Anz4mV4E357PubcBERBkcIebsQM1Nn54XU5kpjHtPFcVWPSD7Na6JlGbKHPQE5rFpdJC9Arg5anNsTTgRskwfG2G60S/hIa8hbSKdk7iPr9xd5ZJ+lfQF6Jf1nfJZANA8MJCLwDpIw4oM384ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777036583; c=relaxed/simple; bh=F8kbzkS+0CgW/YinqjzwsQsRfaDsQBhtAJK7W6rLhMY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=URV63OqeYhAtpowf45axsES/VvhLgZLqgFOtl5zQbm0uU2sdr4zPJ5UrgB0B6rTV+lv9PTufavmz6R2QIP7j8sWZqgVTU7AZismbN/3tZ4+/JfaQ02cu71HdXiciZRn+8Fb7nw/Gb9ddxXFFaDZ6o7eQmrN70uI5o8AH00qkVPs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B12B44BABF19 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 476D66A843 for ; Fri, 24 Apr 2026 13:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777036581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtT8IpOVdAQZOhEEvijBrKEw5mBdQ46aYbXUv6ozfOY=; b=zjjBYyXFQ4pVk/VvApyoiotAH09gQbl96gl9zvM244fjAFJCIWWlnwPI9KQYFmX9C1M2wT LLgBIydwzD7rBneDVADromYmcKp4RpEbVKsu9+iW3Nls01P75PHcYc4ak8MePZ16xb6/V5 JuatXvXzm+oT+chr4/aXP9ZbffsCHfs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777036581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtT8IpOVdAQZOhEEvijBrKEw5mBdQ46aYbXUv6ozfOY=; b=etPf5ue8kjBg+Q5iRdYlq4bJdviZz56SocFRYyxzcngGmqrQfAKx0TGXWaALXpMfWOjskO XX0jus9FFrf0leCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=arztqEzQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XcYDh6Vm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777036577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtT8IpOVdAQZOhEEvijBrKEw5mBdQ46aYbXUv6ozfOY=; b=arztqEzQPmttPEtYzIuNAwvJKjAXMpjrA/uJlj0YN1RmBQ5LZSXRxqZO3rT9c0fVNwHLPI qIJcRfBS83unUh/FEk2JHMPpG+QlCifKART/e7juxzjNSyD7VGEUGj7sktqJAq2aD/svBc qgOEm7w8fNedB3BALnqbUhuinrl9nW8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777036577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtT8IpOVdAQZOhEEvijBrKEw5mBdQ46aYbXUv6ozfOY=; b=XcYDh6VmBGKWMQaEzLfe8arbOIjnJyBeYvE84ETT5oFcbiwi7Zx/f9COoXFMmCkgmGcYi6 yrrKCV63bElaLiAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 35BD6593A4 for ; Fri, 24 Apr 2026 13:16:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KsB4CyFt62loKQAAD6G6ig (envelope-from ) for ; Fri, 24 Apr 2026 13:16:17 +0000 Message-ID: <4c68fd57-f26c-429d-900e-6faa0d48d432@suse.de> Date: Fri, 24 Apr 2026 15:16:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH] [gdb] Improve selftest c_ctrl_unctrl From: Tom de Vries To: gdb-patches@sourceware.org References: <20260326140401.4160862-1-tdevries@suse.de> <790738dd-c257-4cc7-870c-8bb7b08ed1ef@suse.de> Content-Language: en-US In-Reply-To: <790738dd-c257-4cc7-870c-8bb7b08ed1ef@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, sourceware.org:url] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 476D66A843 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/10/26 2:32 PM, Tom de Vries wrote: > On 3/26/26 3:04 PM, Tom de Vries wrote: >> Improve selftest c_ctrl_unctrl by exercising all valid inputs of >> c_iscntrl. >> > > Ping. > I've pushed this. Thanks, - Tom > Thanks, > - Tom > >> Tested on x86_64-linux. >> >> Suggested-By: Tom Tromey [1] >> >> [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226231.html >> --- >>   gdb/utils.c | 24 +++++++++++++++++++++--- >>   1 file changed, 21 insertions(+), 3 deletions(-) >> >> diff --git a/gdb/utils.c b/gdb/utils.c >> index b073bb9fdf3..c8903896081 100644 >> --- a/gdb/utils.c >> +++ b/gdb/utils.c >> @@ -3793,12 +3793,30 @@ test_c_ctrl_unctrl () >>     SELF_CHECK (c_ctrl ('?') == 0x7f); >>     SELF_CHECK (c_unctrl (0x7f) == '?'); >> -  /* Consistency check.  */ >> -  for (unsigned int i = 0; i < 0x100; i++) >> +  /* Consistency check. >> + >> +     The ctype.h function iscntrl has an int parameter, and defined >> behavior >> +     for inputs [0, 255] and EOF.  Consequently, iscntrl has undefined >> +     behavior when called with a negative signed char argument (with the >> +     possible exception of EOF, which is a negative int constant).  That >> +     extends to chars on platforms where char == signed char. >> Consequently, >> +     to write portable code, iscntrl char and signed char arguments >> need to be >> +     cast to unsigned char. >> + >> +     The c-ctype.h variant c_iscntrl sidesteps this problem by having >> defined >> +     behavior for inputs [-128, 255] and not bothering about EOF. >> + >> +     The functions c_ctrl/c_unctrl sidestep this issue by using >> parameter >> +     type unsigned char instead of int. >> + >> +     So, testing input values [0..255] tests all relevant behavior of >> +     c_ctrl/c_unctrl.  However, we designed these functions to be >> compatible >> +     with c_iscntrl, so we test for all valid inputs of that >> function.  */ >> +  for (int i = -128; i < 256; i++) >>       { >>         unsigned char ch = i; >>         unsigned char unctrl_ch = c_unctrl (ch); >> -      if (!c_iscntrl (ch)) >> +      if (!c_iscntrl (i)) >>       { >>         SELF_CHECK (unctrl_ch == ch); >>         continue; >> >> base-commit: edf0ae3b9f1ca23daaa55628683edc9a3360286f >