From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 64cPGRrLUGGuEgAAWB0awg (envelope-from ) for ; Sun, 26 Sep 2021 15:33:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 536DF1EE25; Sun, 26 Sep 2021 15:33:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9EB521EDF0 for ; Sun, 26 Sep 2021 15:33:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F321B3858416 for ; Sun, 26 Sep 2021 19:33:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F321B3858416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632684824; bh=NyGbBLoMoRS1IyH4DoEJKBtxj9RhtXmKooKg3D8nWoM=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hjdbT8dffRkoUTIr3Uw+zo3a0BPdWptn5crg0Wz+PexgVe67+UBgPdcUn/Ad2vVW/ 6RtO5t5kqGAto25JM89A7V3MSTE4fku2c0guhOAiylD6yPmybp9PfeqY/E6qfVpKkU ypjMYkbPLHpLfwQyXyCw0/DvETiwAHLmx8hhEpHY= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 40BED3858C60 for ; Sun, 26 Sep 2021 19:33:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40BED3858C60 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18QJXJ52023617 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 26 Sep 2021 15:33:24 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18QJXJ52023617 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C5B6D1EDF0; Sun, 26 Sep 2021 15:33:18 -0400 (EDT) Message-ID: <4c635f63-2e4d-559e-0d8d-85e77524201e@polymtl.ca> Date: Sun, 26 Sep 2021 15:33:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH][gdb/build] Fix build with g++-4.8 Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20210926091521.GA31054@delia> In-Reply-To: <20210926091521.GA31054@delia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 26 Sep 2021 19:33:19 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > [ I considered just removing the initialization, with the idea that access > should be guarded by has_pc_info, but I ran into one failure in the testsuite, > for gdb.base/check-psymtab.exp due to add_partial_symbol using lowpc without > checking has_pc_info. ] Does that mean you've found a bug in add_partial_symbol? Simon