From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6DTRFlBPWWjanhoAWB0awg (envelope-from ) for ; Mon, 23 Jun 2025 08:57:52 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=bWJg2D8d; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=bWJg2D8d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 41B771E11C; Mon, 23 Jun 2025 08:57:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D0241E0C2 for ; Mon, 23 Jun 2025 08:57:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F2BB38505DF for ; Mon, 23 Jun 2025 12:57:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F2BB38505DF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=bWJg2D8d; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=bWJg2D8d Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::3]) by sourceware.org (Postfix) with ESMTPS id 2D6DD385084D for ; Mon, 23 Jun 2025 12:56:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D6DD385084D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D6DD385084D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::3 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750683417; cv=pass; b=UJFyLKlNqtLmD/77wowjSJF4BEKqhZ6HoeoAoqaWsUD3oUbAeb8gqYGyHGC9nUFDZGLmNx4yGpcU1OePS2uZBA76kmAcGgTvZ7/aFW80H0BKzSXqSdgQRgf3VDuFhIy90n4lqj/Rox+LAOGLOzLnd5U1xR7Y5SVMwgMH1cYi5x4= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750683417; c=relaxed/simple; bh=XZcrfEkjFVoeMTs7LFBryNvS4/eAUFRkYflil0XaSQU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=WIl+P2suz6ZLWGp8p/S2CZDpkwV19g1POvSBWwzaZ9koST3cSKFqXgPPDoN6J/e4usJ7os1eepdIGK3Z1xx4ITeDYmEAcJk+878oBLCjZa68uz8I9Lvbmck5JemfxQ8MN0dlfyYKGpYmWuJkg1DFvzGHHC60yliOxSVnMSD0wOs= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D6DD385084D ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=tzVBYVnknb/PO0HHxZA+YglyDxkzWPR5/Uo2kWcm68QQJ3YVhGWFwcfwZKCQQyF1mEdU1WHELTyXvzBxNqN8ouX2XqIiTyhVcm9eb3JgUuYRtY38wp+l5WpCbDcQxlsXOJ0KX6JBNZ42y5UR5nX0p8MbrDTlQu0oNWavLj7Yg7vjZknuQki+y31okkK0IH6b3keWFqfDGc9xCwo8p+XMt9Q+jE52oi57fC1FGZa7CXJeFRy9U1zjzQEwgvz2TbTApCyg94QrsUQqRdFby1tCf4M7eh03pGe5OlLi+9lkD/qR7f+bT0Vgus8+Xl7BY/2rBVsL2jMZdPSVAyb6ffS47g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dU4Tep092MovoEPvRg9NlJry9LbV8hmbhcZuQEXDRT0=; b=xyYQ0W2PTF4zZheqTxjCfxUGNJw1UoYKJOOE/aMQXfOTNugS4TpmDMbMD2NCKO8byPte8jJgBP90uoNPe9BRBfeyLBI8YTsfTGRAW6Xu8e4m28pQjBITtLFgsmwflm2j+g+e+TqbZj7VfGukvuzUYrBXJYkS6a7wJxiSaAbTWHf9vjU+32Zpp97mNluXn3Ih7XYvEBctsT5EfcYzvY3hAc21DMXHQYbtfd7ADMt23I0ADsG/KDqDQvXaD+dVlVXVGMMwnagir/EeXIVuktYONdoh6UGdojavGIDN5uih+3Mo3IE+ZA46jKvNWHtc0wFsgNHL/octF/x0j9m8Ad2jeg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dU4Tep092MovoEPvRg9NlJry9LbV8hmbhcZuQEXDRT0=; b=bWJg2D8dJer4AYsSWxbGFx7X4qyAAExk3x9chnKjg2K0U1p/zTmm1tsVqZBnfR70dlbX1qNxWMFu7/i/yXh+Gtyd+7o0pZQ6oycRE2+WDn3boBubwGPq6CRcSXTCPiH3sQgaglOsj8bPCe4AE1O4esnJtnhd5CeBWiVhrrMaGpk= Received: from DU2PR04CA0261.eurprd04.prod.outlook.com (2603:10a6:10:28e::26) by AS8PR08MB10144.eurprd08.prod.outlook.com (2603:10a6:20b:630::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 12:56:50 +0000 Received: from DU2PEPF0001E9C4.eurprd03.prod.outlook.com (2603:10a6:10:28e:cafe::ac) by DU2PR04CA0261.outlook.office365.com (2603:10a6:10:28e::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Mon, 23 Jun 2025 12:56:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF0001E9C4.mail.protection.outlook.com (10.167.8.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Mon, 23 Jun 2025 12:56:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RXGlgo82Enim+eQiN+WLR2PDgnbAwYdxqQdJLAIGbmFwDfVH8oKEZn9p5FwI53u65srSLTMTc7ItRpVM8aMqA3SKeWdhzmzPOesH0BrmmtPRqbZCgaiQWVZWNnlPYmeNlY/iB2GEQ5umDMin5Er+Ky11VroM+UyFdrKvBBuqiTKsxSMvW3t1MHUOS2QnIXmbRiIduJnl5eD7wk1bj4OdJI680jqiVm3ZWJA7FC0SH/AeBIkPY1oy8xhRFRSsOCILFsqJMALEHtrGwy9NzTMXmY1oweK35oCUn2864R3RKkyvSuDHTuIQc2lLrAHYEhnq0dwcoDrBpiK3maA9MPEGNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dU4Tep092MovoEPvRg9NlJry9LbV8hmbhcZuQEXDRT0=; b=y/bQ70QQBh8s5HLPBW3mnb1QypuXrv7BGtYlPl2M949iYZwd3kcShL5xOdc9dR/io4oEFx6GL8Dc6z1+YUz7mOyu+JT6X0nICcYJMp3bH3hqdL2W32jGdSCo/yuTINDiq/GeewvqMLq3fbIYkey2IFXbmSr7VxKa8+H1Nk04cklvKy5voIfnWzpgGE5gc8lQ1091zjHfpn5U23OIyQZmUGHaJc9L+TT8kAR7FMG1sGAHIW/CD8y1vFd+NY83cx45KEfsw0oLC8EmNLJFb7RlCKnie3Zdk4c3KoR8B+ZRo/0xMiZ6Vkd/GyyGI/QdW3/V6g8h50Xp+hQsnj+D1G5WUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dU4Tep092MovoEPvRg9NlJry9LbV8hmbhcZuQEXDRT0=; b=bWJg2D8dJer4AYsSWxbGFx7X4qyAAExk3x9chnKjg2K0U1p/zTmm1tsVqZBnfR70dlbX1qNxWMFu7/i/yXh+Gtyd+7o0pZQ6oycRE2+WDn3boBubwGPq6CRcSXTCPiH3sQgaglOsj8bPCe4AE1O4esnJtnhd5CeBWiVhrrMaGpk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by PA6PR08MB10767.eurprd08.prod.outlook.com (2603:10a6:102:3d1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.26; Mon, 23 Jun 2025 12:56:16 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%6]) with mapi id 15.20.8857.025; Mon, 23 Jun 2025 12:56:16 +0000 Message-ID: <4c57870a-7233-49b6-990c-9e6f3b7ce452@arm.com> Date: Mon, 23 Jun 2025 13:56:16 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for target description creation on x86. To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" , "eliz@gnu.org" References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-5-christina.schimpe@intel.com> Content-Language: en-US From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0191.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::16) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|PA6PR08MB10767:EE_|DU2PEPF0001E9C4:EE_|AS8PR08MB10144:EE_ X-MS-Office365-Filtering-Correlation-Id: ba595e58-87fd-4eda-9354-08ddb2556b40 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?ZGQxaTNVcVRZRTl3ayttcnZqSUVJVzZxc2pja1dVQ0RPajF1RG1HZndlTGxX?= =?utf-8?B?QVFQdVd2Z2FCVHJoUXF5b3V3ZmkrZVU5R2cySXZmQ2pGVFM0bUs2MUl4QXZN?= =?utf-8?B?TzAvaTZXb3UvTmhkckpKT2pCeHJtRkFkRGdOTkc2dWIrVW9TTHZhVHRkZWll?= =?utf-8?B?OGhHUXlaS2V1WG5Od0gyM0dXWTU0NG40clFtSnVsci93cnVLM0N2NzQ2b29U?= =?utf-8?B?SGNyQzdvUHg5U0x5dzE3dVdmMnZIUzZBNk1HWEE1MU1DWHlkWHV6U0FncG01?= =?utf-8?B?RWQyV2RzMk0wWE8zWTloRXBaUUlPaWxCd0JZZkVDVmxzYTJ1dllFV3ZTaDZq?= =?utf-8?B?UTRyR0lkYzVlNzBsYi9abnJ1NGVwdytwRjlnVGcrdU5OMjdXMmpVeTlxQ3Jq?= =?utf-8?B?dk80M1dsQk1OWDlMTlJQSFpQalR4QXltOTE5OWRHMVlMa2JUMGxpQWI3TXBY?= =?utf-8?B?Y1l3alJUcEFaZW9nL1ZxVmxjcHdBL1VBSU1FOHk3S2hMU0NlbUFnQXNqOHlp?= =?utf-8?B?dlJNRnNGeEhSWVEram5uRUhvdjdPTkFpaDFOOG1BZ2t3USt0NUFvclQxdThk?= =?utf-8?B?N0dmd0ZRWkRxUHVkN3NaODVyemwvSVVlbWprTUJHeFVmVE90WERwWVFNM1Ba?= =?utf-8?B?MS9HWVVnaGxEN2dNamV1emEwL0YxTVBuL1k2YVVMY05Xa25HdnBveUJTd2hx?= =?utf-8?B?L2M2U2wvc3V5WWsyY1Ribjd6VlVqbWhOdUVuRExsQURGanN4c0c4RkhtRFRV?= =?utf-8?B?TFVaSzNycUlKR3JrMEJrOWdBSXZLRWx2NWxOMW1QQW5lV2tLMTNPanorZ2Nr?= =?utf-8?B?bytob1dONFBzV1pMTURzZEk1WHgxMm4wVG9sWEpyYWtydzZiZEoxVmdIZzln?= =?utf-8?B?ZUNRL0h3ZzcvMkZ2aFVFZGJCalBlcXFMKytSZUxrWXJUT3dHUVNZNGVSSGti?= =?utf-8?B?TndrZzdhL05LdTNyblIzaDRYRTVTdDVXeEdjemxUN1NjY2NQQnZtRUhHZkMv?= =?utf-8?B?VElhZ3B2eW5iUTdhamlmZGdWb1dyeG5zMEZLZjBaaEU2SlVCQ2JKU0NoR0tk?= =?utf-8?B?N052NTZ5TE5UcXVhVGpybDd2aXIxeDRiblZYQ1p0Y2U0UWJwb1J6Z0dYeXQv?= =?utf-8?B?eXBOVFUvRlR2NTZXS3VFU0ovZTROZkRZMEFuRElKWjg0K3RRN0tRd3FXTW5z?= =?utf-8?B?bFI1blExVGQ4U2NnWHBqc0RFbFgvL2IwRWxoMk1LS2c0NWVSNDdFTlR6aVBU?= =?utf-8?B?T2JRU1JtL3BxWlEyYytBdEpaSEdvQ2JmalFOZ1B1Yy9KN1NQTU96Zkt0Wloz?= =?utf-8?B?RkZqTXVhQ1lNQ2ErT3g2ampQaXVuTnEyc3p3VHI0T2ZPNmZrOGdnOG5rREg4?= =?utf-8?B?b0Y2Y1FmZ3FzV2UxQUpSblZzK2FTV25KQlc5QlR6UVhqdUs2bGhlMjk0VFA5?= =?utf-8?B?SVRnamdiQ2p3MUoxVlhPeEhkZFlYanBMZmx2RkNUZ3FoZGFwNWdPRTFiTkhT?= =?utf-8?B?MkJLUDdQd2o3QUR4UzFDY0NEQTArZUg5WEg3Y1VTRkJZOTJGUndGNHFGeTFE?= =?utf-8?B?TG1yU21XTTZackFxbTViNjZycyt6aEFHblV5aitoM004MDFQekJuMXFVZk1G?= =?utf-8?B?YVNOY013RTQrZWZRYWEzY2dtZFJOcjFFTXNkYlhSR2F3MXl5cEpSeG1WSWVH?= =?utf-8?B?b1kyb2NGNU1jaVJ2eFF6Z2F4Z1ZDRXY0Y0R6Y2pTOHhWZGdya1dsYk1sUlFj?= =?utf-8?B?WGl4QnhkSERFNXpYNVJsQWluOVhkc1RNTkJ4WWtwcldSeHR4dTRnSGNOL21P?= =?utf-8?B?WTJ2N0FQb2hKQ1lITmRrelZwOFVMMEIvQnRhYWhmRXhiOUhSa1dTcThHekxB?= =?utf-8?B?UzkremRpM29EdVlNcUNhWDByOExwV3d5MktqWmVoeHRvUC9VM3c1bnd6RjhF?= =?utf-8?Q?AX7JRuczb64=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10767 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF0001E9C4.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18bf481e-cadc-416c-0c6c-08ddb2555774 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013|14060799003|35042699022|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a2pBeEVSWTYrQW04TnV6aDNmMHVwSjB6RmNlWHNBVE9veEFrNFhUTFVROGI4?= =?utf-8?B?ZEZUL2E0QmlYVEJXTVRRRk5CNzFmSUt0clRoWjB3aWVxcnRDT3ZsUS9BaFFN?= =?utf-8?B?L1NNcUR3bUwzOWZ3dmRRQkk3WkdDV0FIY0ZmRlBnTTgyZHAydU5TZTRpWmx6?= =?utf-8?B?ejBpdG5HWkozL0tBRVNZd2xsaXNFWm1MZ05lTzRQMWtZQ2NuYjhsamV2cDBT?= =?utf-8?B?d1NGdWhjN0JveHV1ZzhPQXpINktuNkVBQ0xuTG1BZUIzSWRpY0JMTEhFeDkr?= =?utf-8?B?TXFOWHlFeWx1R3E4VlFwR3NNN04rcWZDU1Z6ZHpmZTZhVGE2Qk5QTisyS1BN?= =?utf-8?B?bDhYUFdPa3owQTVMZ1NDUVkxZnJ5YWZ0Z2VuS1lRQ3Vzdk9RNlJsamZTaERx?= =?utf-8?B?dUsrT2VTYU9IcG5yMlFBci9xYmJsbGdSSCtIVE9IWWo2SGdhNUw4SW9oOWNE?= =?utf-8?B?MjdJQzB6WEY2T201YjRYbk02cUY3SER5bVFNYm1sVjRQNWU2QXc2ejF4TU5D?= =?utf-8?B?QndIL2hHOEVRVkZMWkxuZVlUZklJcTg5a2NIeG1tVkJiQndHd0lUTU5pbjhC?= =?utf-8?B?RzZjZnJBVW4rYmNLUU1XZ21sZElzQzhIWE1TTTN1bkhjMDFkeElIaEdyVVBv?= =?utf-8?B?bE5nZkxDK1NEclc5NEt3aXA5Z0tsdVZCSFVJaFNIVWpxZnJ4MWxEZUpsNUVH?= =?utf-8?B?T2pvSHNwRHpJbVc5L21SdFdlaytEV3l3dUJXWjYxZ3FOczB2QnZjTkJTVmV4?= =?utf-8?B?eDdEbXI5dHJ5WCtCdUNON1o1d0plVFFmOTJiNkdGdFhNeXVZTGorOW52VXhK?= =?utf-8?B?ZStWZzJPWTdxWUhNbjl3MjhUd3ZaVFFlVU5HZVArNXpUcWltUWV5emk2QndW?= =?utf-8?B?SmZqT0lhWi85cDhEMjVVV3BLalFHcWVzWTJnWmlUUVRuWU9rZHlyMDZmU0xU?= =?utf-8?B?TmpKazlWT3c2REdaOTVMM1lEKzZwdk9LbnJrV0lITjd3cFB0YnVBWFNabmlL?= =?utf-8?B?T3N4ZE9BcW5FRU5XOU54NWQ4dVRpUnhRMnovRWpWbjNUU20rWmJvcmZuNEV5?= =?utf-8?B?VjFSSVRhN3lac0RVTFpRY2llMVRhMHZyS3JncG8yZGlYa25tNkJGTUFVK3Rm?= =?utf-8?B?M3ZDUEhDeGk1NDY2M2pOd0QwQ0ZRNjFLcmxlWktqcmhlS252ODBjL2pZUEVa?= =?utf-8?B?aDJrSDZNeEtRZEJkdi90Z3RMbE82bjJETXRuTlBIN1c1d094ckhZbG5RcFpD?= =?utf-8?B?QndwMHhzTXBTZFNhcExSRnY1Sm1NcDY2YUxGTFI0UDFlMzNoUFBDSTdwVFFa?= =?utf-8?B?T0hxczhOVDM2Zm5DMXBENGtrT25WUjUyWUk1aEx1U1o3cjR4Yi85M2VZTDla?= =?utf-8?B?VHl4LzV0em1ZbXZEWjkwMzFVY1BUN2NMaS9RblRUVmdMcGVueTNibXAzYm1I?= =?utf-8?B?L1M2YWtjSkUzMDdXamxBRkZsNjc5UFZmKzNKbVNEdUg1ejAxM01HUDdIeEdx?= =?utf-8?B?MUNmRGc1cGh0KzJCWUV2RitFQlhwTnN5cXlrQ09DWW5XZ3hhVGMxa2ZHVFpJ?= =?utf-8?B?a0REcHczQjdGOHV5THBuYWN3cHJHLzNXWk5sa3kxNFdnL1Rqd1FYY2l1VnRQ?= =?utf-8?B?V0RXaVhWWVg4U0Z6UEJpMFVBWTZBRVdIWXgrOVlvYlNoWkorclVTRnF0YW1D?= =?utf-8?B?cS9BRmlId21FR1o0YWM5MHBPbXBVcU1SR3kvTllCMUVTTHpSb0M1akFTQVRD?= =?utf-8?B?RVhhdm5wSVFnMSttMHJLc0FGeEkwQ1lQdW8yanVZaTZhSkcvRWlxNzNnYTI2?= =?utf-8?B?Z1Q1MlhQNkNUZmJvU2EybFUrWkMxRmRBWE94ZFZldDVDd1dEL1ExK0trM1Zj?= =?utf-8?B?OURlTTM3REVUVE0yWWxmWjVVMWV5VGlhMGoxYkhUNEVWTkJVVEt1c0VhTU1P?= =?utf-8?B?NGVxK2JUckJVSzdlVi80bFZMNzEzRUJXZy9IdEQ0cFhsZ3JwMlE1cXJmQjVF?= =?utf-8?B?WmpkVERReVRUdWd3RHFGTkZ0dTEyNlhRVGlnbFJBWGNweWhmWlAxOUNLckxE?= =?utf-8?Q?3m4YXM?= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013)(14060799003)(35042699022)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 12:56:49.6734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba595e58-87fd-4eda-9354-08ddb2556b40 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C4.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10144 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/23/25 13:46, Schimpe, Christina wrote: > Hi Luis, > > Thanks a lot for the feedback. Please find my comments below. > >> -----Original Message----- >> From: Luis Machado >> Sent: Thursday, June 19, 2025 11:24 AM >> To: Schimpe, Christina ; gdb- >> patches@sourceware.org >> Cc: thiago.bauermann@linaro.org; eliz@gnu.org >> Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for target >> description creation on x86. >> >> On 6/17/25 13:11, Christina Schimpe wrote: >>> diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c index >>> 252650b6390..9cac0645cdc 100644 >>> --- a/gdb/arch/amd64.c >>> +++ b/gdb/arch/amd64.c >>> @@ -30,14 +30,11 @@ >>> >>> #include "../features/i386/x32-core.c" >>> >>> -/* Create amd64 target descriptions according to XCR0. If IS_X32 is >>> - true, create the x32 ones. If IS_LINUX is true, create target >>> - descriptions for Linux. If SEGMENTS is true, then include >>> - the "org.gnu.gdb.i386.segments" feature registers. */ >>> +/* See amd64.h. */ >> >> More appropriate to reference arch/amd64.h. > > True, will fix. > >> >>> >>> target_desc * >>> -amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, >>> - bool segments) >>> +amd64_create_target_description (uint64_t xstate_bv_mask, bool is_x32, >>> + bool is_linux, bool segments) >>> { >>> target_desc_up tdesc = allocate_target_description (); >>> >>> @@ -62,13 +59,13 @@ amd64_create_target_description (uint64_t xcr0, >> bool is_x32, bool is_linux, >>> if (segments) >>> regnum = create_feature_i386_64bit_segments (tdesc.get (), >>> regnum); >>> >>> - if (xcr0 & X86_XSTATE_AVX) >>> + if (xstate_bv_mask & X86_XSTATE_AVX) >>> regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum); >>> >>> - if (xcr0 & X86_XSTATE_AVX512) >>> + if (xstate_bv_mask & X86_XSTATE_AVX512) >>> regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum); >>> >>> - if (xcr0 & X86_XSTATE_PKRU) >>> + if (xstate_bv_mask & X86_XSTATE_PKRU) >>> regnum = create_feature_i386_pkeys (tdesc.get (), regnum); >>> >>> return tdesc.release (); >> >> <...> >> >>> diff --git a/gdb/arch/i386.c b/gdb/arch/i386.c index >>> 835df53c75d..84f31439e7a 100644 >>> --- a/gdb/arch/i386.c >>> +++ b/gdb/arch/i386.c >>> @@ -29,10 +29,11 @@ >>> #include "../features/i386/32bit-segments.c" >>> #include "../features/i386/pkeys.c" >>> >>> -/* Create i386 target descriptions according to XCR0. */ >>> +/* See i386.h. */ >> >> arch/i386.h > > Will fix. > >> >>> >>> target_desc * >>> -i386_create_target_description (uint64_t xcr0, bool is_linux, bool >>> segments) >>> +i386_create_target_description (uint64_t xstate_bv_mask, bool is_linux, >>> + bool segments) >>> { >>> target_desc_up tdesc = allocate_target_description (); >>> >>> @@ -44,10 +45,10 @@ i386_create_target_description (uint64_t xcr0, >>> bool is_linux, bool segments) >>> >>> long regnum = 0; >>> >>> - if (xcr0 & X86_XSTATE_X87) >>> + if (xstate_bv_mask & X86_XSTATE_X87) >>> regnum = create_feature_i386_32bit_core (tdesc.get (), regnum); >>> >>> - if (xcr0 & X86_XSTATE_SSE) >>> + if (xstate_bv_mask & X86_XSTATE_SSE) >>> regnum = create_feature_i386_32bit_sse (tdesc.get (), regnum); >>> >>> if (is_linux) >>> @@ -56,13 +57,13 @@ i386_create_target_description (uint64_t xcr0, bool >> is_linux, bool segments) >>> if (segments) >>> regnum = create_feature_i386_32bit_segments (tdesc.get (), >>> regnum); >>> >>> - if (xcr0 & X86_XSTATE_AVX) >>> + if (xstate_bv_mask & X86_XSTATE_AVX) >>> regnum = create_feature_i386_32bit_avx (tdesc.get (), regnum); >>> >>> - if (xcr0 & X86_XSTATE_AVX512) >>> + if (xstate_bv_mask & X86_XSTATE_AVX512) >>> regnum = create_feature_i386_32bit_avx512 (tdesc.get (), regnum); >>> >>> - if (xcr0 & X86_XSTATE_PKRU) >>> + if (xstate_bv_mask & X86_XSTATE_PKRU) >>> regnum = create_feature_i386_pkeys (tdesc.get (), regnum); >>> >>> return tdesc.release (); >> >> <...> >> >>> diff --git a/gdb/x86-linux-nat.c b/gdb/x86-linux-nat.c index >>> fc7c5f642ed..a82ad21da27 100644 >>> --- a/gdb/x86-linux-nat.c >>> +++ b/gdb/x86-linux-nat.c >>> @@ -97,15 +97,20 @@ const struct target_desc * >>> x86_linux_nat_target::read_description () { >>> /* The x86_linux_tdesc_for_tid call only reads xcr0 the first time it is >>> - called, the xcr0 value is stored here and reused on subsequent calls. */ >>> - static uint64_t xcr0_storage; >>> + called. The mask is stored in XSTATE_BV_STORAGE and reused on >>> + subsequent calls. Note that GDB currently supports features for user >>> + state components only. However, once supervisor state components are >>> + supported in GDB XSTATE_BV_STORAGE will not be configured based on >>> + xcr0 only. */ >> >> Something about the comment above reads off in the last phrase. Is there a >> missing connection word? > > I agree, would this be a bit better? > > "However, once supervisor state components are supported in GDB, the value > XSTATE_BV_STORAGE will not be configured based on xcr0 only." > Yes, that reads better, thanks. I don't think you need a new iteration for these fixes though. They could be local. >> >>> + static uint64_t xstate_bv_storage; >>> >>> if (inferior_ptid == null_ptid) >>> return this->beneath ()->read_description (); >>> >>> int tid = inferior_ptid.pid (); >>> >>> - return x86_linux_tdesc_for_tid (tid, &xcr0_storage, >>> &this->m_xsave_layout); >>> + return x86_linux_tdesc_for_tid (tid, &xstate_bv_storage, >>> + &this->m_xsave_layout); >>> } >>> > >> Otherwise this looks OK to me. I suppose this was regression tested? I'd be a bit >> more comfortable if someone more knowledgeable could chime in before this >> gets approved. >> >> But if nobody shows up, we can get it in if others have no concerns. >> >> Reviewed-By: Luis Machado > > Yes, this has been regression tested (recent testing for v4 on ubuntu 24.04). > I am currently working on the setup for testing x32 again. This configuration has been tested for v1 initially only. Alright. Thanks for confirming.